Re: [Minios-devel] lib/ukmmap: Fix return type and add supress flag for cleaner build.

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi Simon, sounds good, I'll send a v2.

-- Felipe

On Fri, Feb 14, 2020 at 1:06 AM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
>
>
> On 13.02.20 21:58, Felipe Huici wrote:
> > Fix the return type of mremap and add -Wno-unused-parameter to provide
> > a cleaner build.
> >
> > Signed-off-by: Felipe Huici <felipe.huici@xxxxxxxxx
> > ---
> >   lib/ukmmap/Makefile.uk | 2 ++
> >   lib/ukmmap/mmap.c      | 2 +-
> >   2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/lib/ukmmap/Makefile.uk b/lib/ukmmap/Makefile.uk
> > index 71ff432..498a2ca 100644
> > --- a/lib/ukmmap/Makefile.uk
> > +++ b/lib/ukmmap/Makefile.uk
> > @@ -1,3 +1,5 @@
> >   $(eval $(call addlib_s,libukmmap,$(CONFIG_LIBUKMMAP)))
> >
> >   LIBUKMMAP_SRCS-y += $(LIBUKMMAP_BASE)/mmap.c
> > +
> > +LIBUKMMAP_CFLAGS-y += -Wno-unused-parameter
> > diff --git a/lib/ukmmap/mmap.c b/lib/ukmmap/mmap.c
> > index 52c49e2..e1259da 100644
> > --- a/lib/ukmmap/mmap.c
> > +++ b/lib/ukmmap/mmap.c
> > @@ -168,5 +168,5 @@ int munmap(void *addr, size_t len)
> >   void *mremap(void *old_address, size_t old_size, size_t new_size,
> >               int flags, ...)
>
> For internal libs it is generally better to use `__unused` helper macro
> (uk/essentials.h) instead of suppressing warnings.
>
> >   {
> > -     return -1;
> > +     return 0;
>
> return NULL;
> >   }
> >
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel