Re: [Minios-devel] [UNIKRAFT/NEWLIB PATCH] Makefile.uk: -Wno-char-subscripts as global flag

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi Simon, thanks for the fix.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Mon, Feb 17, 2020 at 8:06 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Exposes the GCC suppress flag `-Wno-char-subscripts` globally. The
> header <ctype.h> is causing the warning to appear when the
> macros islower, isupper, tolower, toupper are used.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile.uk | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 66c3b88..b59c428 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -94,13 +94,13 @@ LIBNEWLIB_GLOBAL_FLAGS-y  += -D_LDBL_EQ_DBL
>  LIBNEWLIB_GLOBAL_FLAGS-y  += -D_HAVE_LONG_DOUBLE
>  endif
>
> -CFLAGS-y   += $(LIBNEWLIB_GLOBAL_FLAGS-y)
> -CXXFLAGS-y += $(LIBNEWLIB_GLOBAL_FLAGS-y)
> +CFLAGS-$(CONFIG_LIBNEWLIBC)   += $(LIBNEWLIB_GLOBAL_FLAGS-y)
> +CXXFLAGS-$(CONFIG_LIBNEWLIBC) += $(LIBNEWLIB_GLOBAL_FLAGS-y)
>
>  # Suppress some warnings to make the build process look neater
>  LIBNEWLIB_SUPPRESS_FLAGS-y += \
>  -Wno-unused-parameter -Wno-unused-variable -Wno-nonnull                      
>           \
> --Wno-unused-but-set-variable -Wno-unused-label -Wno-char-subscripts          
>   \
> +-Wno-unused-but-set-variable -Wno-unused-label                               
>           \
>  -Wno-unused-function -Wno-missing-field-initializers -Wno-uninitialized      
>           \
>  -Wno-array-bounds -Wno-maybe-uninitialized -Wno-pointer-sign 
> -Wno-unused-value \
>  -Wno-unused-macros -Wno-parentheses -Wno-implicit-function-declaration       
>   \
> @@ -121,6 +121,10 @@ LIBNEWLIBGLUE_SUPPRESS_FLAGS-y += -Wno-unused-parameter
>  LIBNEWLIBGLUE_CFLAGS-y   += $(LIBNEWLIBGLUE_SUPPRESS_FLAGS-y)
>  LIBNEWLIBGLUE_CXXFLAGS-y += $(LIBNEWLIBGLUE_SUPPRESS_FLAGS-y)
>
> +LIBNEWLIB_GLOBAL_SUPPRESS_FLAGS-y += -Wno-char-subscripts
> +CFLAGS-$(CONFIG_LIBNEWLIBC)   += $(LIBNEWLIB_GLOBAL_SUPPRESS_FLAGS-y)
> +CXXFLAGS-$(CONFIG_LIBNEWLIBC) += $(LIBNEWLIB_GLOBAL_SUPPRESS_FLAGS-y)
> +
>  
> ################################################################################
>  # OS dependencies code - Glue between Unicore and newlib
>  
> ################################################################################
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel