[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT/SQLITE PATCH] sqlite: Use implicit-fallthrough only for gcc > 7



Hey the patch looks good. A question: Don't you want to use -Wno-implicit-fallthrough instead of -Wimplicit-fallthrough=0 - this would be then inline with the other suppress flags that we are using.

Thanks,

Simon

On 18.02.20 22:20, Sharan Santhanam wrote:
The patch uses the flag -Wimplicit-fallthrough only for while
compiling with gcc > 7.0.

Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
---
  Makefile.uk | 8 +++++---
  1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/Makefile.uk b/Makefile.uk
index f0a7afd..f8287b7 100644
--- a/Makefile.uk
+++ b/Makefile.uk
@@ -66,11 +66,13 @@ LIBSQLITE_CINCLUDES += -I$(LIBSQLITE_SRC)
  LIBSQLITE_FLAGS = -D_HAVE_SQLITE_CONFIG_H -DSQLITE_OMIT_LOAD_EXTENSION
# Suppress some warnings to make the build process look neater
-LIBSQLITE_SUPPRESS_FLAGS += -Wno-unused-parameter -Wno-unused-variable         
\
--Wno-cast-function-type -Wno-char-subscripts -Wimplicit-fallthrough=0          
\
+LIBSQLITE_SUPPRESS_FLAGS-y += -Wno-unused-parameter -Wno-unused-variable       
        \
+-Wno-cast-function-type -Wno-char-subscripts
+
+LIBSQLITE_SUPPRESS_FLAGS-$(call gcc_version_ge,7,0) +=-Wimplicit-fallthrough=0 
        \
LIBSQLITE_CFLAGS-y += $(LIBSQLITE_FLAGS)
-LIBSQLITE_CFLAGS-y += $(LIBSQLITE_SUPPRESS_FLAGS)
+LIBSQLITE_CFLAGS-y += $(LIBSQLITE_SUPPRESS_FLAGS-y)
################################################################################
  # Glue code


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.