Re: [Minios-devel] [UNIKRAFT PATCH 1/1] Fix crash caused by the Optimize for Performance config option

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey,

thanks a lot for figuring this problem out. However, can you send this 
as a patch to the affected repositories (ruby, micropython)? I think we 
should not set this everywhere if not needed.
You can add the flags globally from within the Makefule.uk of each 
library by doing (for example libruby):
CFLAGS-$(CONFIG_LIBRUBY)   += -fno-gcse -fno-gnu-unique \
                              -fno-move-loop-invariants
CXXFLAGS-$(CONFIG_LIBRUBY) += -fno-gcse -fno-gnu-unique \
                              -fno-move-loop-invariants
GOFLAGS-$(CONFIG_LIBRUBY)  += -fno-gcse -fno-gnu-unique \
                              -fno-move-loop-invariants

Thanks,

Simon

On 19.02.20 09:36, Vlad-Andrei BĂDOIU (78692) wrote:
> We disable the gcse, gnu-unique, and move-loop-invariants
> flags enabled by O2. This solves the crash on several external
> libraries(e.g. ruby, micropython).
>
> Signed-off-by: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> ---
>   Makefile.uk | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 67c372e5..359973f3 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -31,9 +31,9 @@ LDFLAGS     += -nostdinc -nostdlib -Wl,--omagic 
> -Wl,--build-id=none
>   CFLAGS-$(CONFIG_OPTIMIZE_NONE)            += -O0 -fno-optimize-sibling-calls 
> -fno-tree-vectorize
>   CXXFLAGS-$(CONFIG_OPTIMIZE_NONE)          += -O0 -fno-optimize-sibling-calls 
> -fno-tree-vectorize
>   GOCFLAGS-$(CONFIG_OPTIMIZE_NONE)          += -O0 -fno-optimize-sibling-calls 
> -fno-tree-vectorize
> -CFLAGS-$(CONFIG_OPTIMIZE_PERF)            += -O2
> -CXXFLAGS-$(CONFIG_OPTIMIZE_PERF)          += -O2
> -GOCFLAGS-$(CONFIG_OPTIMIZE_PERF)          += -O2
> +CFLAGS-$(CONFIG_OPTIMIZE_PERF)            += -O2 -fno-gcse -fno-gnu-unique 
> -fno-move-loop-invariants
> +CXXFLAGS-$(CONFIG_OPTIMIZE_PERF)          += -O2 -fno-gcse -fno-gnu-unique 
> -fno-move-loop-invariants
> +GOCFLAGS-$(CONFIG_OPTIMIZE_PERF)          += -O2 -fno-gcse -fno-gnu-unique 
> -fno-move-loop-invariants
>   CFLAGS-$(CONFIG_OPTIMIZE_SIZE)            += -Os
>   CXXFLAGS-$(CONFIG_OPTIMIZE_SIZE)          += -Os
>   GOCFLAGS-$(CONFIG_OPTIMIZE_SIZE)          += -Os
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel