Re: [Minios-devel] [UNIKRAFT PATCH] build: Call `gitsha1` from Unikraft base

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi Simon, thanks for the patch.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Thu, Feb 20, 2020 at 10:34 AM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Calls `support/scripts/gitsha1` from the Unikraft base folder. The
> script supposely detects the current Git commit hash and figures out
> if there are uncommitted changes. The script's output is added to the
> version number.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 17708bef..725b012a 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -199,9 +199,9 @@ include $(CONFIG_UK_BASE)/version.mk
>  # Compute the full local version string so packages can use it as-is
>  # Need to export it, so it can be got from environment in children (eg. 
> mconf)
>  ifdef UK_EXTRAVERSION
> -export UK_FULLVERSION := 
> $(UK_VERSION).$(UK_SUBVERSION).$(UK_EXTRAVERSION)$(shell 
> $(SCRIPTS_DIR)/gitsha1)
> +export UK_FULLVERSION := 
> $(UK_VERSION).$(UK_SUBVERSION).$(UK_EXTRAVERSION)$(shell cd 
> $(CONFIG_UK_BASE); $(SCRIPTS_DIR)/gitsha1)
>  else
> -export UK_FULLVERSION := $(UK_VERSION).$(UK_SUBVERSION)$(shell 
> $(SCRIPTS_DIR)/gitsha1)
> +export UK_FULLVERSION := $(UK_VERSION).$(UK_SUBVERSION)$(shell cd 
> $(CONFIG_UK_BASE); $(SCRIPTS_DIR)/gitsha1)
>  endif
>
>  # Default image name
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel