[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v2] Fix crash caused by the "Optimize for Performance" config option



Thanks Simon.

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Thu, Feb 20, 2020 at 1:48 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> From: Vlad-Andrei BĂDOIU (78692) <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
>
> We disable the gcse, gnu-unique, and move-loop-invariants
> flags enabled by O2.
>
> Signed-off-by: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@xxxxxxxxxxxxxxx>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile.uk | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 14e10fa..88747cc 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -101,6 +101,13 @@ LIBMICROPYTHON_CFLAGS-y += -DUNIX -DN_X64 -D 
> MICROPY_PY_LWIP  \
>                            -Wno-unused-but-set-variable       \
>                            -Wno-unused-function
>
> +LIBMICROPYTHON_OPTIMIZATIONS += -fno-gcse -fno-gnu-unique \
> +                               -fno-move-loop-invariants
> +
> +CFLAGS-$(CONFIG_LIBMICROPYTHON)   += $(LIBMICROPYTHON_OPTIMIZATIONS)
> +CXXFLAGS-$(CONFIG_LIBMICROPYTHON) += $(LIBMICROPYTHON_OPTIMIZATIONS)
> +GOFLAGS-$(CONFIG_LIBMICROPYTHON)  += $(LIBMICROPYTHON_OPTIMIZATIONS)
> +
>  
> ################################################################################
>  # Unikraft <-> Micropython glue code
>  
> ################################################################################
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.