Re: [Minios-devel] [UNIKRAT RFC PATCH] build: Introduce flag CFLAGS_REMOVE to remove some options

[Justin He <Justin.He@xxxxxxx>]

Hi Simon and Felipe
This patch is the proposal as we discussed in last meeting.
After this patch, in newlib Makefile, we need to add 
Ifeq (ARM_64, y)
CFLAGS_REMOVE=-mgeneral-regs-only
endif

What do you think of it
--
Cheers,
Justin (Jia He)


> -----Original Message-----
> From: Jia He <justin.he@xxxxxxx>
> Sent: Monday, February 24, 2020 2:31 PM
> To: minios-devel@xxxxxxxxxxxxxxxxxxxx; Simon Kuenzer
> <simon.kuenzer@xxxxxxxxx>; Santiago.Pagani@xxxxxxxxx
> Cc: Sharan.Santhanam@xxxxxxxxx; Felipe Huici <felipe.huici@xxxxxxxxx>;
> Julien Grall <Julien.Grall@xxxxxxx>; Kaly Xin <Kaly.Xin@xxxxxxx>; Justin He
> <Justin.He@xxxxxxx>
> Subject: [UNIKRAT RFC PATCH] build: Introduce flag CFLAGS_REMOVE to
> remove some options
> 
> Previously, there is no way to remove any global options for individual
> library. For some reason, on arm64 we need to use mgeneral-regs-only
> for unikraft plat library (context switch, print debug). But for some
> other libraries (e.g. newlib), we shouldn't use that option due to
> float point/simd support on arm64.
> 
> This patch adds a new flag CFLAGS_REMOVE to filter it out in unikraft
> build system.
> 
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
>  support/build/Makefile.rules | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/support/build/Makefile.rules b/support/build/Makefile.rules
> index d60c6d9..dea2c7f 100644
> --- a/support/build/Makefile.rules
> +++ b/support/build/Makefile.rules
> @@ -391,7 +391,9 @@ $(3): $(2) | prepare
>       $(call build_cmd_fixdep,CC,$(1),$(3),\
>               $(CC)  $(CINCLUDES) $(CINCLUDES-y) \
>                      $($(call vprefix_lib,$(1),CINCLUDES)) $($(call
> vprefix_lib,$(1),CINCLUDES-y)) \
> -                    $(CFLAGS) $(CFLAGS-y) $(DBGFLAGS) $(DBGFLAGS-y) \
> +                    $(filter-out $(CFLAGS_REMOVE),$(CFLAGS)) \
> +                       $(filter-out $(CFLAGS_REMOVE),$(CFLAGS-y)) \
> +                       $(DBGFLAGS) $(DBGFLAGS-y) \
>                      $($(call vprefix_lib,$(1),CFLAGS)) $($(call
> vprefix_lib,$(1),CFLAGS-y)) \
>                      $(4) -D__LIBNAME__=$(1) -D__BASENAME__=$(notdir $(2))
> \
>                      -c $(2) -o $(3) $(depflags)
> --
> 2.17.1


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel