Re: [Minios-devel] [UNIKRAFT PATCH 0/5] initramfs support

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Robert, Omar, Sachin,

many thanks for your work! I finally was able to review your important 
series. We really want this feature in. We successfully tried it already 
and it worked. We build our CPIO archive on Linux with
  find . -depth -print | tac | bsdcpio -o --format newc > ../initrd.cpio

Is this the intended way? Maybe you want to document this in your cover 
letter.
Since this is will become a quite important feature, I gave you a deep 
review with many suggestions for making it a perfect series. I am 
looking forward to a v2. ;-)
Thanks,

Simon


On 28.01.20 05:01, Robert Hrusecky wrote:
> This patch series introduces functionality required for supporting
> initramfs, including a new memory region for the linuxu platform, as
> well as CPIO extraction library.
>
> We've added the system calls needed to read the initrd file passed by a
> library parameter for the linuxu platform. CPIO extraction code is
> contained in a new library and is based on the FreeBSD implementation.
> If a CPIO archive is provided, it is extracted and its contents are
> mounted as the root filesystem with ramfs.
>
> Robert Hrusecky (5):
>    plat/linuxu: Add fstat and open host system calls
>    plat/linuxu: Add initrd memory region
>    lib/cpio: Create empty CPIO extraction library
>    lib/cpio: Add CPIO extraction functionality
>    lib/vfscore: Add support to mount initramfs to root
>
>   lib/Makefile.uk                             |   1 +
>   lib/cpio/Makefile.uk                        |   7 +
>   lib/cpio/cpio.c                             | 239 ++++++++++++++++++++
>   lib/cpio/exportsyms.uk                      |   1 +
>   lib/cpio/include/uk/cpio.h                  |  57 +++++
>   lib/vfscore/Config.uk                       |  12 +
>   lib/vfscore/rootfs.c                        |  32 ++-
>   plat/linuxu/include/linuxu/setup.h          |  11 +-
>   plat/linuxu/include/linuxu/syscall-arm_32.h |   1 +
>   plat/linuxu/include/linuxu/syscall-x86_64.h |   1 +
>   plat/linuxu/include/linuxu/syscall.h        |  15 ++
>   plat/linuxu/memory.c                        | 105 +++++++--
>   12 files changed, 456 insertions(+), 26 deletions(-)
>   create mode 100644 lib/cpio/Makefile.uk
>   create mode 100644 lib/cpio/cpio.c
>   create mode 100644 lib/cpio/exportsyms.uk
>   create mode 100644 lib/cpio/include/uk/cpio.h
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel