[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v4 0/4] lib/uksp: Introduce uksp library



Hi Vlad,

thanks a lot for your work. I have some suggestion inline in each patch. Let me know what you think.

Thanks,

Simon

On 04.02.20 15:09, Vlad-Andrei BĂDOIU (78692) wrote:
Currently, we provide a basic implementation of stack smashing
protection that
has a global value for all threads. The value is randomly initialized
during the
boot. Finally, this option might help us detect bugs caused by stack
overflows.

Changes since v1:
* We now use a choice based config option for the stack protector level.
* Since
the last version we added the regulat and strong stack protector
options.

Changes since v2:
* Renamed the library to uksp

Changes since v3:
* Added config option for constant value/random source for the canary.
* Updated the config
* Updated library title
* Moved uksp/stackprotector.h to uk/sp.h
* Added current stack pointer to the crash message

Vlad-Andrei Badoiu (2):
   Move UK_SWRAND_CTOR_PRIO to uk/swrand.h
   lib/ukboot: Initialize the canary value at boot

Vlad-Andrei BĂDOIU (78692) (2):
   lib/uksp: Introduce uksp library
   build: Add option to toggle the stack protection

  Makefile.uk                      | 10 ++++--
  lib/Config.uk                    |  4 +++
  lib/Makefile.uk                  |  1 +
  lib/ukboot/boot.c                |  8 +++++
  lib/uksp/Config.uk               | 51 ++++++++++++++++++++++++++++
  lib/uksp/Makefile.uk             | 21 ++++++++++++
  lib/uksp/exportsyms.uk           |  2 ++
  lib/uksp/include/uk/sp.h         | 58 ++++++++++++++++++++++++++++++++
  lib/uksp/ssp.c                   | 50 +++++++++++++++++++++++++++
  lib/ukswrand/include/uk/swrand.h |  2 ++
  lib/ukswrand/swrand.c            |  2 --
  11 files changed, 205 insertions(+), 4 deletions(-)
  create mode 100644 lib/uksp/Config.uk
  create mode 100644 lib/uksp/Makefile.uk
  create mode 100644 lib/uksp/exportsyms.uk
  create mode 100644 lib/uksp/include/uk/sp.h
  create mode 100644 lib/uksp/ssp.c


_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.