Re: [Minios-devel] [UNIKRAFT PATCH] lib/nolibc: Introduce strtok_r

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hey Costin,

Thanks a lot for looking into this. However, I don't think we should 
overdo this separation with nolibc. In the case of newlib and other more 
posix fundemantal libs, I fully support the procedure but I do not see 
the gains for nolibc. I think it is cleaner to put this into string.c.
Thanks,

Simon

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 08.10.19 17:18, Costin Lupu wrote:
> On 10/8/19 12:18 PM, Sharan Santhanam wrote:
> > Hello Costin,
> >
> > On 10/7/19 9:43 PM, Costin Lupu wrote:
> > > Hi Sharan,
> > >
> > > All code imported from musl should go to musl-imported/ subdirectory of
> > > lib/nolibc. This way we can differentiate what's of musl origin from the
> > > other stuff.
> > In this case I added it to string.c as the other related function strtok
> > and strspn which was also imported from musl is in the same file.
> Yes, I know. That's what I'm suggesting: we should do it differently
> from now on. Everything that's imported from musl should go to
> musl-imported/. Of course, we should correct the past changes as well,
> but this will happen some other time.
>
> Cheers,
> Costin
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel
_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel