Re: [Minios-devel] [UNIKRAFT/FLATBUFFERS PATCH 1/2] Library skeleton

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi George,

Thanks for these patches, I have a few comments inline.

-- Felipe

On Wed, Mar 18, 2020 at 12:53 PM George Muraru <murarugeorgec@xxxxxxxxx> wrote:
>
> Signed-off-by: George Muraru <murarugeorgec@xxxxxxxxx>
> ---
>  .gitignore      | 27 +++++++++++++++++++++++++++
>  CODING_STYLE.md |  4 ++++
>  CONTRIBUTING.md |  4 ++++
>  COPYING.md      | 29 +++++++++++++++++++++++++++++
>  Config.uk       |  6 ++++++
>  MAINTAINERS.md  | 10 ++++++++++
>  README.md       |  5 +++++
>  7 files changed, 85 insertions(+)
>  create mode 100644 .gitignore
>  create mode 100644 CODING_STYLE.md
>  create mode 100644 CONTRIBUTING.md
>  create mode 100644 COPYING.md
>  create mode 100644 Config.uk
>  create mode 100644 MAINTAINERS.md
>  create mode 100644 README.md
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..75d2fd3
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,27 @@
> +*.depend
> +*.o
> +*.a
> +*.d
> +*.so
> +*.orig
> +*.rej
> +*.bak
> +*.swp
> +*~
> +,*
> +\#*\#
> +.\#*
> +\#_*\#
> +.\#_*
> +!.gitignore
> +.*
> +
> +# gnu global files
> +GPATH
> +GRTAGS
> +GSYMS
> +GTAGS
> +
> +# cscope files
> +cscope.*
> +ncscope.*
> diff --git a/CODING_STYLE.md b/CODING_STYLE.md
> new file mode 100644
> index 0000000..5730041
> --- /dev/null
> +++ b/CODING_STYLE.md
> @@ -0,0 +1,4 @@
> +Coding Style
> +============
> +
> +Please refer to the `CODING_STYLE.md` file in the main Unikraft repository.
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> new file mode 100644
> index 0000000..5f55eca
> --- /dev/null
> +++ b/CONTRIBUTING.md
> @@ -0,0 +1,4 @@
> +Contributing to Unikraft
> +=======================
> +
> +Please refer to the `CONTRIBUTING.md` file in the main Unikraft repository.
> diff --git a/COPYING.md b/COPYING.md
> new file mode 100644
> index 0000000..7d73c6d
> --- /dev/null
> +++ b/COPYING.md
> @@ -0,0 +1,29 @@
> +License
> +=======
> +
> +Unikraft flatbuffers wrapper
> +-----------------------
> +
> +This repository contains wrapper code to build Flatbuffers with Unikraft.
> +Each C code file in this repository should declare who is the
> +copyright owner and under which terms and conditions the code is
> +licensed. If such a licence note is missing, the following copyright
> +notice will apply:
> +
> +       Copyright (c) 2020, University Politehnica of Bucharest. All rights
> +       reserved.
> +
> +       This library is free software; you can redistribute it and/or
> +       modify it under the terms of the GNU Lesser General Public
> +       License as published by the Free Software Foundation; either
> +       version 2 of the License, or (at your option) any later version.
> +
> +       This library is distributed in the hope that it will be useful,
> +       but WITHOUT ANY WARRANTY; without even the implied warranty of
> +       MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> +       Lesser General Public License for more details.
> +
> +       You should have received a copy of the GNU Lesser General Public
> +       License along with this library in the file COPYING.LIB;
> +       if not, write to the Free Software Foundation, Inc.,
> +       59 Temple Place - Suite 330, Boston, MA 02111-1307, USA

This license looks a bit strange, please have a look at some of the
COPYING.md files in other repos  (e.g., libgo)

> diff --git a/Config.uk b/Config.uk
> new file mode 100644
> index 0000000..3794c0a
> --- /dev/null
> +++ b/Config.uk
> @@ -0,0 +1,6 @@
> +menuconfig LIBFLATBUFFERS
> +    bool "FlatBuffers - cross platform serialization library"
> +    select LIBCXX
> +    select LIBNEWLIBC
> +    select LIBPOSIX_SYSINFO
> +    default n

You're missing the following deps from Config.uk:

+    select LIBCXXABI
+    select LIBCOMPILER_RT
+    select LIBUNWIND

> diff --git a/MAINTAINERS.md b/MAINTAINERS.md
> new file mode 100644
> index 0000000..389474f
> --- /dev/null
> +++ b/MAINTAINERS.md
> @@ -0,0 +1,10 @@
> +Maintainers List
> +================
> +
> +For notes on how to read this information, please refer to `MAINTAINERS.md` 
> in
> +the main Unikraft repository.
> +
> +       LIBFLATBUFFERS-UNIKRAFT
> +       M:      George Muraru <murarugeorgec@xxxxxxxxx>
> +       L:      minios-devel@xxxxxxxxxxxxx
> +       F: *
> diff --git a/README.md b/README.md
> new file mode 100644
> index 0000000..27117d8
> --- /dev/null
> +++ b/README.md
> @@ -0,0 +1,5 @@
> +libflatbuffers for Unikraft
> +===================
> +
> +Please refer to the `README.md` as well as the documentation in the `doc/`
> +subdirectory of the main unikraft repository.

Here we tend to list this lib's dependencies. You can have a look at
another lib (e.g,. protobuf)

> --
> 2.17.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel