Re: [Minios-devel] [UNIKRAFT PATCH v3 7/8] build: Move detection of submake call after cmdline variables

["felipehuici ." <felipehuici@xxxxxxxxx>]

Reviewed-by: Felipe Huici <felipe.huici@xxxxxxxxx>

On Fri, Mar 27, 2020 at 4:36 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:
>
> Moves the detection of submake call to a place after the command-line
> variables are processed. This is done for readability reasons of the
> main Makefile.
>
> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
> ---
>  Makefile | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9dc87f3c..a605fad4 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -164,12 +164,6 @@ $(if $(wildcard $(E)), \
>  )
>  endif
>  EPLAT_DIR := $(realpath $(patsubst %/,%,$(patsubst %.,%,$(EPLAT_DIR))))
> -build_dir_make  := 0
> -ifneq ($(BUILD_DIR),$(UK_BASE))
> -       build_dir_make := 1;
> -else
> -       sub_make_exec := 1;
> -endif
>
>  # ELIB_DIR (list of external libraries)
>  # Retrieved from L variable from the command line (paths separated by colon)
> @@ -195,6 +189,13 @@ $(call verbose_info,* External platforms: [ $(EPLAT_DIR) 
> ])
>  $(call verbose_info,* External libraries: [ $(ELIB_DIR) ])
>  $(call verbose_info,* Build output:       $(BUILD_DIR))
>
> +build_dir_make  := 0
> +ifneq ($(BUILD_DIR),$(UK_BASE))
> +       build_dir_make := 1;
> +else
> +       sub_make_exec := 1;
> +endif
> +
>  # KConfig settings
>
>  CONFIG_UK_PLAT        := $(CONFIG_UK_BASE)/plat/
> --
> 2.20.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel