[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Minios-devel] [UNIKRAFT PATCH v2 0/7] Support float point on arm64 kvm plat



Hi Justin, thanks so much for this new series! One of the patches
doesn't apply cleanly, could please do a quick rebase and submit a new
version?

Thanks!

-- Felipe

On Fri, Mar 27, 2020 at 10:48 AM Jia He <justin.he@xxxxxxx> wrote:
>
> This series is to enable the float point support on arm64 kvm plat.
>
> The key point is the patch 3 and 4
>
> Tested on a ThundX2 qemu virt guest machine.
> qemu command line:/usr/local/bin/qemu-system-aarch64  \
> -machine virt,gic-version=2 -m 1024 -cpu max -no-acpi -smp 1 \
> -display none  -nographic -nodefaults -serial stdio \
> -kernel build/helloworld_kvm-arm64
>
> I created a app with 2 threads, and then print their local double/float
> variables. Looks fine to me.
>
> Changes:
> v2: remove RFC tag.
>     utilize 'isr' variant feature introduced by Simon, this addresses the
> mgeneral-regs-only issue in v1.
>     refactor the save/restore codes due to license issue.
>
> Jia He (7):
>   plat: build: Add a config option to enable fp on arm64
>   build: Link libgcc at the end of the link options list
>   plat/kvm: arm64: Enable the fp/simd at the starting point
>   plat/arm: Support fp/simd save/restore during context switch
>   arch/arm64: Don't pass -mgeneral-regs-only when CONFIG_FLOAT_POINT is
>     y
>   arch/arm64: Fix -mfpu=none when not supporting fpsimd
>   build: Add 'isr' variant for arm64 kvm plat source files called within
>     irq context
>
>  arch/arm/arm64/Makefile.uk          |  7 ++-
>  plat/Config.uk                      |  7 +++
>  plat/common/arm/thread_start64.S    | 72 +++++++++++++++++++++++++++++
>  plat/common/include/arm/arm64/cpu.h | 46 +++++++++++++++++-
>  plat/kvm/Linker.uk                  |  2 +
>  plat/kvm/Makefile.uk                | 10 ++--
>  plat/kvm/arm/entry64.S              |  8 ++++
>  7 files changed, 143 insertions(+), 9 deletions(-)
>
> --
> 2.17.1
>
>
> _______________________________________________
> Minios-devel mailing list
> Minios-devel@xxxxxxxxxxxxxxxxxxxx
> https://lists.xenproject.org/mailman/listinfo/minios-devel

_______________________________________________
Minios-devel mailing list
Minios-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/minios-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.