Re: [UNIKRAFT/LIBCOMPILERRT PATCH 2/2] Add clrsbdi2 to makefile

["felipehuici ." <felipehuici@xxxxxxxxx>]

Hi George,

Thanks for the patch! Unfortunately, they don't build as they are,
please see inline.

-- Felipe

On Sun, Apr 12, 2020 at 4:40 PM George Muraru <murarugeorgec@xxxxxxxxx> wrote:
>
> Signed-off-by: George Muraru <murarugeorgec@xxxxxxxxx>
> ---
>  Makefile.uk | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 23f9e2e..6be65fa 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -238,3 +238,5 @@ LIBCOMPILER_RT_SRCS-$(CONFIG_ARCH_X86_64) += 
> $(LIBCOMPILER_RT_SRC)/lib/builtins/
>  ifdef CONFIG_LIBCOMPILER_RT_ATOMIC
>  LIBCOMPILER_RT_SRCS-y += $(LIBCOMPILER_RT_SRC)/lib/builtins/atomic.c
>  endif
> +
> +LIBCOMPILER_RT_SRCS-y += $(LIBCOMPILER_RT_SRC)/lib/builtins/clrsbdi2.c

The line above should read LIBCOMPILER_RT_SRCS-y +=
$(LIBCOMPILER_RT_BASE)/lib/builtins/clrsbdi2.c , otherwise it points
to a non-existing file, breaking the build.

> --
> 2.17.1
>
>