Re: [UNIKRAFT PATCH v2 6/9] lib/uk9p: Change severity of uk_9p_version log

[Costin Lupu <costin.lupu@xxxxxxxxx>]

Reviewed-by: Costin Lupu <costin.lupu@xxxxxxxxx>

On 5/9/20 7:44 PM, Cristian Banu wrote:
> Even though 9p can continue execution if the negotiated message
> size violates the 9p specification, this should be a warning,
> not a debug message.
> 
> Also fixes a typo "Howevver".
> 
> Signed-off-by: Cristian Banu <cristb@xxxxxxxxx>
> ---
>  lib/uk9p/9p.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/uk9p/9p.c b/lib/uk9p/9p.c
> index 14ba299..4acb0c6 100644
> --- a/lib/uk9p/9p.c
> +++ b/lib/uk9p/9p.c
> @@ -116,12 +116,12 @@ struct uk_9preq *uk_9p_version(struct uk_9pdev *dev,
>  
>       /*
>        * Note: the 9P specification mentions that new_msize <= dev->msize.
> -      * Howevver, execution can continue even if the invariant is violated
> +      * However, execution can continue even if the invariant is violated
>        * and set_msize() fails, as the old message size is always within the
>        * accepted limit.
>        */
>       if (!uk_9pdev_set_msize(dev, new_msize))
> -             uk_pr_debug("Invalid new message size.\n");
> +             uk_pr_warn("Invalid new message size.\n");
>  
>       return req;
>  
>