Re: [UNIKRAFT PATCH 1/1] build: Add -fno-split-stack

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Reviewed-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>

On 11.05.20 02:54, Vlad-Andrei Badoiu wrote:
> Until recently we have been using -fno-split-stack for GO source.
> This flag was dropped by mistake in the recent commits.
> We add this flag back since LD does not have full split stack
> support.
>
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>
> ---
>   Makefile.uk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index 1d6d060a..2c102989 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -6,7 +6,7 @@
>   
>   COMPFLAGS    += -nostdinc -nostdlib
>   COMPFLAGS    += -U __linux__ -U __FreeBSD__ -U __sun__
> -COMPFLAGS    += -fno-stack-protector -fno-omit-frame-pointer -fno-tree-sra
> +COMPFLAGS    += -fno-stack-protector -fno-omit-frame-pointer -fno-tree-sra 
> -fno-split-stack
>   COMPFLAGS    += -Wall -Wextra
>   
>   ASFLAGS      += -D__ASSEMBLY__