[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
RE: [UNIKRAFT PATCH RFCv2 26/27] plat/virtio_9p: Fix max virtqueue number 1024 on arm64
- To: Justin He <Justin.He@xxxxxxx>, "minios-devel@xxxxxxxxxxxxxxxxxxxx" <minios-devel@xxxxxxxxxxxxxxxxxxxx>
- From: Justin He <Justin.He@xxxxxxx>
- Date: Fri, 29 May 2020 07:00:57 +0000
- Accept-language: en-US, zh-CN
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=au8GxDwtgkTbgOslzu08kxY+4CVBtVpWi6mcMrYkhJY=; b=QkC/ncOsGFKemddebRKLW74SJibMtsW+aazzxv7/Yq4ZjWmRhpV6A2yL5dve9U1CRTcT6mKaeJl/+uCy8IFbtA3qNpJgC4o0ZwKa1GL5cjI5YFm6oRnR1W4VnS+VyLk4Wf3DEVounwMe/8lInZH6RLdvO04kUcq4MLjBfFOWiqsm4bdhJkJvE5YLDfLa6XOMdmAioxpNTtdQbW+ORajiayFWAkp1V2qd/nya2qCJO/jY/9y4phbFdjDf7+abs57YEK1giC8Qss3TQ+X0JKtYVuhqljpmNXbU7FJ03i/EwxzyC/Bkv6uIchETHQ/CGJjfUqdu+99wrIvHT0ZCwRVhYQ==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GL+MNsnDLCtYByE+mGo0JQ7W6tq8/5JKg0mouw3XVd14tZXK6CSVyyelOvm0qoSaDi4UGHVBvpbrCr8cS/LRdfyHIiMu8CimmManp8fcKaMli6oYTWOXZbkGcDnetAy4xvd/zRsBtiVrdRnf8jeSqqBLT22uHSXO4oeXD6MluwYRacRjjGO9MC8mcwV0F+oNZ6AqNFA6EfcOPC8oy8+t70gbyQ+jUAqh+Ng49EoTdSxj8JC0HC//6itfCgja+TyyYpKFLhm2Jb9nWnCuvkCWPf/CUT7FNyXpF5uSsuSfqFhXIqV/J/bKW9UhmB/8PahAtvi1h/4AR59bJOVpLzIUzQ==
- Authentication-results-original: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Cc: Felipe Huici <felipe.huici@xxxxxxxxx>, Kaly Xin <Kaly.Xin@xxxxxxx>, Simon Kuenzer <simon.kuenzer@xxxxxxxxx>, "Sharan.Santhanam@xxxxxxxxx" <Sharan.Santhanam@xxxxxxxxx>
- Delivery-date: Fri, 29 May 2020 07:01:15 +0000
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
- Nodisclaimer: true
- Original-authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=arm.com;
- Thread-index: AQHWNX5DCCYHq7rT0kmjTX93Sc1/Sqi+ohKQ
- Thread-topic: [UNIKRAFT PATCH RFCv2 26/27] plat/virtio_9p: Fix max virtqueue number 1024 on arm64
> -----Original Message-----
> From: Jia He <justin.he@xxxxxxx>
> Sent: Friday, May 29, 2020 1:57 PM
> To: minios-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>;
> Sharan.Santhanam@xxxxxxxxx; Felipe Huici <felipe.huici@xxxxxxxxx>; Kaly
> Xin <Kaly.Xin@xxxxxxx>; Justin He <Justin.He@xxxxxxx>
> Subject: [UNIKRAFT PATCH RFCv2 26/27] plat/virtio_9p: Fix max virtqueue
> number 1024 on arm64
>
> On arm64, the virtqueue max number provided by qemu is 1024.
> Otherwise, it reports:
> Expected 128 descriptors, found 1024 (virtqueue
>
I am not sure it will have impact on x86 codes.
Maybe we could dynamically allocate NUM_SEGMENTS by probing
virtio-device since it is different btw arm64 virtio mmio and x86 virtio
pci device.
--
Cheers,
Justin (Jia He)
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
> plat/drivers/virtio/virtio_9p.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plat/drivers/virtio/virtio_9p.c b/plat/drivers/virtio/virtio_9p.c
> index fe0d69a..b29b1cb 100644
> --- a/plat/drivers/virtio/virtio_9p.c
> +++ b/plat/drivers/virtio/virtio_9p.c
> @@ -44,7 +44,7 @@
> #include <uk/plat/spinlock.h>
>
> #define DRIVER_NAME"virtio-9p"
> -#define NUM_SEGMENTS128 /** The number of virtqueue descriptors.
> */
> +#define NUM_SEGMENTS1024 /** The number of virtqueue
> descriptors. */
> static struct uk_alloc *a;
>
> /* List of initialized virtio 9p devices. */
> --
> 2.17.1
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are not the intended recipient,
please notify the sender immediately and do not disclose the contents to any
other person, use it for any purpose, or store or copy the information in any
medium. Thank you.
|
