Re: [UNIKRAFT/LIB-NGINX PATCH] Makefile.uk: Bump NGINX to v1.18.0

[George-Cristian Muraru <murarugeorgec@xxxxxxxxx>]

Hey Alex,

I applied the changes from this series against the 'staging' branch.

I tried to build the library with the default configuration.

I added some comments,

Other than that, looks good to me.

 LIBNGINX_BASENAME = nginx-$(LIBNGINX_VERSION)

Add 'release' (ex: 'nginx-release-$(LIBNGINX_VERSION')

 

-LIBNGINX_URL = http://nginx.org/download/$(LIBNGINX_BASENAME).tar.gz

It also needs a 'release' to (ex: 'release-$(LIBNGINX_BASENAME).tar.gz')

+LIBNGINX_URL = https://github.com/nginx/nginx/archive/release-v$(LIBNGINX_VERSION).tar.gz

 Remove the 'v' (ex: https://github.com/nginx/nginx/archive/release-$(LIBNGINX_VERSION).tar.gz 

Reviewed-by: George Muraru <murarugeorgec@xxxxxxxxx>