Re: [UNIKRAFT/VFSCORE PATCH] Remove default value

[Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>]

Hi,

looks fine to me. This does not change the current behavior
since LIBVFSCORE_ROOTFS_RAMFS is the first item in the list.

Reviewed-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>

On Thu, 2020-05-21 at 23:22 +0300, George Muraru wrote:
> Setting a specific value to a choice config (from one of the
> libraries) cannot
> overwrite a default value (that is set in Unikraft). It seems this is
> the case
> for our C based Kconfig (from my knowledge we use this) - a default
> value set
> earlier (in Unikraft) has a higher priority than a one set later (in
> a library).
> 
> For solving this issue, one solution is to use "named choices" - did
> that for
> the tensorflowlite porting.
> 
> The information is obtained from an issue discussed here[1].
> 
> [1] https://github.com/zephyrproject-rtos/zephyr/issues/6948
> 
> Signed-off-by: George Muraru <murarugeorgec@xxxxxxxxx>
> ---
>  lib/vfscore/Config.uk | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/lib/vfscore/Config.uk b/lib/vfscore/Config.uk
> index f64810f..212575c 100644
> --- a/lib/vfscore/Config.uk
> +++ b/lib/vfscore/Config.uk
> @@ -28,7 +28,6 @@ help
>  if LIBVFSCORE_AUTOMOUNT_ROOTFS
>       choice LIBVFSCORE_ROOTFS
>       prompt "Default root filesystem"
> -     default LIBVFSCORE_ROOTFS_RAMFS
>  
>               config LIBVFSCORE_ROOTFS_RAMFS
>               bool "RamFS"