Re: [UNIKRAFT PATCH 2/2] lib/ukboot: initialize ukallocregion

[Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>]

Hi Simon,

one comment, inline.

regards,
Hugo

On Mon, 2020-06-22 at 16:23 +0200, Hugo Lefeuvre wrote:
> Add menuconfig bindings to select a system-wide allocator.
> Initialize the selected allocator in ukboot.
> 
> Signed-off-by: Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>
> ---
>  lib/ukboot/Config.uk | 26 ++++++++++++++++++++++----
>  lib/ukboot/boot.c    | 19 +++++++++++++------
>  2 files changed, 35 insertions(+), 10 deletions(-)
> 
> diff --git a/lib/ukboot/Config.uk b/lib/ukboot/Config.uk
> index 841a876..e4b356b 100644
> --- a/lib/ukboot/Config.uk
> +++ b/lib/ukboot/Config.uk
> @@ -17,8 +17,26 @@ if LIBUKBOOT
>       int "Maximum number of arguments (max. size of argv)"
>       default 60
>  
> -     config LIBUKBOOT_INITALLOC
> -     bool "Initialize ukallocbbuddy as allocator"
> -     default y
> -     select LIBUKALLOCBBUDDY
> +     choice LIBUKBOOT_INITALLOC
> +     prompt "Default memory allocator"
> +     default LIBUKBOOT_INITBBUDDY
> +
> +             config LIBUKBOOT_INITBBUDDY
> +             bool "Binary buddy allocator"
> +             default y

I just noticed these "default" entries. They are not legal in a choice
block. I'll wait for you to do the actual review first, but this will
require a v2 to get rid of them.

> +             select LIBUKALLOCBBUDDY
> +
> +             config LIBUKBOOT_INITREGION
> +             bool "Region allocator"
> +             default n
> +             select LIBUKALLOCREGION
> +             help
> +               Satisfy allocation as fast as possible. No support
> for free().
> +               Refer to help in ukallocregion for more
> information.
> +
> +             config LIBUKBOOT_NOALLOC
> +             bool "No memory allocator"
> +             default n
> +
> +     endchoice
>  endif