Re: [UNIKRAFT PATCH v2 0/2] ipaddr, netmask and gwaddr as library argument

[Hugo Lefeuvre <hugo.lefeuvre@xxxxxxxxx>]

Hi Sharan,

I have sent comments for each of the two patches. I have tested them
and both are working as expected. This is a very nice addition :-)

The v2 should be mergeable as soon as "Poll based receive based on
uk_netdev features" has been upstreamed. We will also need "[Minios-
devel,UNIKRAFT/LWIP,v2,1/3] init.c: Retrieve IP v4 address from device
information" which I reviewed separately.

thanks!

regards,
Hugo

On Tue, 2020-06-30 at 12:51 +0200, Sharan Santhanam wrote:
> The patch series allow user to pass the ip address, net mask and the
> gateway
> address as a library argument to the uknetdev library. The library
> arguments
> are net.ipv4_addr, net.ipv4_subnet_mask and net.ipv4_gw_addr.
> 
> Changes since v1:
> -Make it ipv4 specific
> 
> Sharan Santhanam (2):
>   lib/uknetdev: Add ipaddr, netmask & gwaddr as arg
>   lib/uknetdev: Get the ipaddr, gw_addr and subnet
> 
>  lib/uknetdev/Config.uk                |  1 +
>  lib/uknetdev/Makefile.uk              |  1 +
>  lib/uknetdev/include/uk/netdev_core.h |  8 +++
>  lib/uknetdev/netdev.c                 | 91
> +++++++++++++++++++++++++++
>  4 files changed, 101 insertions(+)
>