Re: [PATCH v2] mini-os: Use a single start_info_ptr variable

[Samuel Thibault <samuel.thibault@xxxxxxxxxxxx>]

Costin Lupu, le mer. 19 août 2020 19:03:50 +0300, a ecrit:
> On 8/19/20 6:50 PM, Samuel Thibault wrote:
> > Costin Lupu, le mer. 19 août 2020 18:45:36 +0300, a ecrit:
> >> +++ b/shutdown.c
> >> @@ -46,7 +46,7 @@
> >>  #include <mini-os/xmalloc.h>
> >>  
> >>  
> >> -static start_info_t *start_info_ptr;
> >> +extern start_info_t *start_info_ptr;
> > 
> > Please rather put the declaration in include/kernel.h
> 
> How about we leave this one as it is and I send a new patch depending on
> this one introducing the `arch_suspend()` function I was mentioning in a
> previous email? This way we will get rid of the declaration from
> `shutdown.c`.
> 
> My concern is that if we move the declaration to `kernel.h` then the
> "message" will be that it is a variable that can be used freely,
> regardless the architecture.

Right, while the structure itself is arch-independent, the availability
depends on the arch.

Samuel