Re: [[UNIKRAFT/LIBS PATCH]] Removed exportsyms.uk from Makefile.uk

[Simon Kuenzer <simon.kuenzer@xxxxxxxxx>]

Hi Cristian,

thanks a lot for this patch. From your patch I can see that this goes to 
pthread embedded. In such a case the subject prefix should say 
"[UNIRKAFT/LIBPTHREAD-EMBEDDED PATH]". We have such a patch already 
accepted in the staging branch of pthread-embedded. I know, it is time 
to follow-up the master branch since this became a show-stopper when 
mixing branches across libraries ;-) . In general I recommend to use 
same branches for all libraries and the core: either `master` or `staging`.
Thanks,

Simon

On 18.08.20 15:32, Cristian Vijelie wrote:
> ---
>   Makefile.uk | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/Makefile.uk b/Makefile.uk
> index b9b7456..4ee37cd 100644
> --- a/Makefile.uk
> +++ b/Makefile.uk
> @@ -59,8 +59,6 @@ LIBPTHREAD-EMBEDDED_CFLAGS-y   += 
> $(LIBPTHREAD-EMBEDDED_SUPPRESS_FLAGS) \
>         -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast
>   LIBPTHREAD-EMBEDDED_CXXFLAGS-y += $(LIBPTHREAD-EMBEDDED_SUPPRESS_FLAGS)
>   
> -LIBPTHREAD-EMBEDDED_EXPORTS = $(LIBPTHREAD-EMBEDDED_BASE)/exportsyms.uk
> -
>   
> ################################################################################
>   # OS dependencies code - Glue between Unikraft and pthread-embedded
>   
> ################################################################################