[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT PATCH v4 00/12] Introduce Xen Netfront driver



On 8/20/20 6:45 PM, Simon Kuenzer wrote:
> Hi Costin,
> 
> really, thanks a lot for picking up this patch series and driving it for
> upstreaming! This is great news. Lets make 2020 a lucky year for
> netfront ;-). I add a few comments inline to some patches that I briefly
> checked (I did a non-detailed review).
> 
> Please also consider the outstanding update to the Ethernet macro
> definitons in lib/uknetdev: https://patchwork.unikraft.org/patch/738013/
> . Since Intel DPDK and in general NFV is one of our targets, we should
> support VLAN tags. This has an effect to the maximum transmission unit
> (1522 B). Do you know if your netfront driver can handle such frame
> sizes (more or less) out-of-the box? As far as I understood, we have
> some restrictions with our virtio driver currently and need to re-visit
> this.

I just want to be super clear about this. These patches have been
sitting on both internal repos and public lists for way too long, it's
been 2 years since the first version. And I'm doing these patches on my
spare time. I'm not going to add any more functionality to them, I will
just accept the minor comments. It's either you will upstream the v5 or
you will have to find someone else to upstream these.

Costin



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.