[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT PATCH v4 12/12] lib/uknetdev: Enable default drivers

Hello Costin,

Please find the comments inline

Thanks & Regards


On 8/13/20 10:53 AM, Costin Lupu wrote:
Currently, for KVM and Xen we only have one network driver each. We enable
them by default whenever uknetdev library is enabled.

Signed-off-by: Costin Lupu <costin.lupu@xxxxxxxxx>
  lib/uknetdev/Config.uk | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/lib/uknetdev/Config.uk b/lib/uknetdev/Config.uk
index 186dd462..2af47efb 100644
--- a/lib/uknetdev/Config.uk
+++ b/lib/uknetdev/Config.uk
@@ -5,6 +5,8 @@ menuconfig LIBUKNETDEV
        select LIBUKDEBUG
        select LIBUKALLOC
        imply LIBUKLIBPARAM
+       imply VIRTIO_NET if PLAT_KVM
+       imply XEN_NETFRONT if PLAT_XEN

Instead of imply we can set `default y if LIBUKNETDEV` in each of the driver kconfig.

What do you think?




Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.