Re: [UNIKRAFT/LIBICU PATCH 0/2] Introducing libicu port to Unikraft

[felipehuici <felipehuici@xxxxxxxxx>]

Hi Razvan,

On Fri, Sep 18, 2020 at 11:18 AM Razvan Deaconescu
<razvan.deaconescu@xxxxxxxxx> wrote:
>
> Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx> writes:
> > Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx> writes:
> >> Hi, Felipe.
> >>
> >> I built the libicu library, everything is OK.
> >>
> >> But the header files are not included in the Makefile commands that
> >> build the application. I used the libicu API in the main.c (application
> >> source code file) and it fails to find header files.
> >>
> >> The header files are included in the Makefile commands to build the
> >> library files:
> >> ---
> >> ... 
> >> -I/home/razvan/projects/unicore/unikraft/apps/app-helloworld.git/build/libicu/origin/source/common
> >> -I/home/razvan/projects/unicore/unikraft/apps/app-helloworld.git/build/libicu/origin/source/i18n
> >> ...
> >> ---
> >>
> >> The Makefile.uk file looks OK to me. Do you know what the problem might be?
> >
> > Simon highlighted the issue in Makefile.uk. It uses CONFIG_ICU instead
> > of CONFIG_LIBICU. Once this is fixed, everything works OK. Like this:
> >
> > ----
> > CINCLUDES-$(CONFIG_LIBICU)   += -I$(LIBICU_SRC)/common
> > CINCLUDES-$(CONFIG_LIBICU)   += -I$(LIBICU_SRC)/i18n
> > CXXINCLUDES-$(CONFIG_LIBICU) += -I$(LIBICU_SRC)/common
> > CXXINCLUDES-$(CONFIG_LIBICU) += -I$(LIBICU_SRC)/i18n

Ok, sounds good, I'll send a v2 fixing this.

Thanks,

-- Felipe

> > ---
>
> Hi, Felipe.
>
> Please see the discussion above. That change is all that's required to
> have libicu ready for upstream.
>
> Razvan
>
> >> Felipe Huici <felipe.huici@xxxxxxxxx> writes:
> >>> This is our initial port of the International Components for Unicode 
> >>> library to Unikraft.
> >>>
> >>> Felipe Huici (2):
> >>>   Introduce icu to Unikraft.
> >>>   Add documentation
> >>>
> >>>  .gitignore      |  27 +++
> >>>  CODING_STYLE.md |   4 +
> >>>  CONTRIBUTING.md |   4 +
> >>>  COPYING.md      |  30 ++++
> >>>  Config.uk       |  14 ++
> >>>  MAINTAINERS.md  |  10 ++
> >>>  Makefile.uk     | 466 ++++++++++++++++++++++++++++++++++++++++++++++++
> >>>  README.md       |  10 ++
> >>>  8 files changed, 565 insertions(+)
> >>>  create mode 100644 .gitignore
> >>>  create mode 100644 CODING_STYLE.md
> >>>  create mode 100644 CONTRIBUTING.md
> >>>  create mode 100644 COPYING.md
> >>>  create mode 100644 Config.uk
> >>>  create mode 100644 MAINTAINERS.md
> >>>  create mode 100644 Makefile.uk
> >>>  create mode 100644 README.md
>