[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT PATCH 5/7] lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`

To: Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>
From: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
Date: Tue, 22 Dec 2020 16:31:47 +0100
Cc: <minios-devel@xxxxxxxxxxxxx>
Delivery-date: Tue, 22 Dec 2020 15:31:57 +0000
List-id: Mini-os development list <minios-devel.lists.xenproject.org>

I will keep the word setup in line 51 but adopt the others. A proper APIdocumentation is actually really important, thanks a lot for pointingout. Somehow I had missed it.


On 04.12.20 12:35, Laurentiu Barbulescu wrote:

This is affecting only the consistency, but you omitted to modify some comments 
from `blkdev.h`:
- on line 54: "*      - uk_blkdev_queue_setup()";
- on line 51, 200, 501: other non-API comments.

References:
- Re: [UNIKRAFT PATCH 5/7] lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`
  - From: Laurentiu Barbulescu

Prev by Date: Re: [UNIKRAFT PATCH 3/7] lib/ukblkdev: blkreq.h: Use typedef for __sector
Next by Date: [UNIKRAFT PATCH v2 0/7] lib/ukblkdev: Minor API improvements and fixes
Previous by thread: Re: [UNIKRAFT PATCH 5/7] lib/ukblkdev: API refactoring: `uk_blkdev_queue_configure()`
Next by thread: Re: [UNIKRAFT/LIBP11-KIT v2 0/4] Reworked port of p11-kit
Index(es):
- Date
- Thread

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.