Re: [UNIKRAFT PATCH v2 2/7] lib/ukblkdev: blkreq.h: Include <uk/arch/atomic.h>

[Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>]

Hi Simon,

Looks good to me.

Reviewed-by: Laurentiu Barbulescu <lrbarbulescu@xxxxxxxxx>

On Tue, Dec 22, 2020 at 5:38 PM Simon Kuenzer <simon.kuenzer@xxxxxxxxx> wrote:

The header `blkreq.h` uses atomic operations but did not include
`<uk/arch/atomic.h>`.

Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
---
 lib/ukblkdev/include/uk/blkreq.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/ukblkdev/include/uk/blkreq.h b/lib/ukblkdev/include/uk/blkreq.h
index 2c4b9b993..17daa6b52 100644
--- a/lib/ukblkdev/include/uk/blkreq.h
+++ b/lib/ukblkdev/include/uk/blkreq.h
@@ -48,6 +48,8 @@ extern "C" {
 #endif

 #define __sector size_t
+#include <uk/arch/atomic.h>
+
 struct uk_blkreq;

 /**
--
2.20.1