Re: [External] [UNIKRAFT PATCH 0/2] Fixes to the virtio library

["Jung, Alexander (Student)" <a.jung@xxxxxxxxxxxxxxx>]

Hi Sharan,

Thanks for this series.  Applying this to staging branch has resulted in a fix 
for
what is currently a broken mount to 9pfs.

Without this series, running (for example):

 qemu-guest -k ./build/nginx_kvm-x86_64 -m 64 -e ./fs0 -a "vfs.rootdev=fs0 --"

Would result in the following error:

[    0.100652] ERR:  [libkvmvirtio9p] <virtio_9p.c @  386> virtio-9p: Failed to 
negotiate the device feature -11
[    0.105531] ERR:  [libkvmvirtio] <virtio_bus.c @  162> Failed to add the 
virtio device 0x2db010: -22
[    0.109986] ERR:  [libkvmvirtio] <virtio_pci.c @  417> Failed to register 
the virtio device: -22
[    0.114250] ERR:  [libkvmpci] <pci_bus.c @  228> PCI 00:02.00: Failed to 
initialize device driver
[    0.119161] CRIT: [libvfscore] <rootfs.c @   85> Failed to mount /: 0
[    0.122318] ERR:  [libukboot] <boot.c @  100> Init function at 0x122a60 
returned error -1

I will mark each patch as reviewed.

Thanks,

Alexander Jung,

Ph.D Student,
Networking & Systems Research Group, 
Lancaster University
net.scc.lancs.ac.uk

F4D5 C6B6 9139 4942 9407  7F54 ED30 1A8A 1763 1B62

> On 8. Jan 2021, at 10:00, Sharan Santhanam <sharan.santhanam@xxxxxxxxx> wrote:
> 
> This email originated outside the University. Check before clicking links or 
> attachments.
> 
> The patch series fixes two bugs in the 9p driver and the virtio bus.
> The first one causes the virtio-9p driver to fail to mount a file system
> and the other adds an error check which was missed on the previous patch.
> 
> Sharan Santhanam (2):
> plat/virtio: virtio_config_get returns >= 0
> plat/virtio: Add error check for tag name
> 
> plat/drivers/include/virtio/virtio_bus.h |  2 +-
> plat/drivers/virtio/virtio_9p.c          | 15 ++++++++++++---
> 2 files changed, 13 insertions(+), 4 deletions(-)
> 
> --
> 2.20.1
> 
>