Re: [UNIKRAFT PATCH 1/1] Cast value to unsigned to avoid undefined behavior

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Vlad,

Thanks for the work.

Reviewed-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>


Sharan

On 1/3/21 3:18 AM, Vlad-Andrei Badoiu wrote:
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>
> ---
>   plat/common/pci_bus.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/plat/common/pci_bus.c b/plat/common/pci_bus.c
> index cfc404e..7a66e94 100644
> --- a/plat/common/pci_bus.c
> +++ b/plat/common/pci_bus.c
> @@ -80,7 +80,7 @@ static struct pci_bus_handler ph;
>   #define PCI_BUS_SHIFT               (16)
>   #define PCI_DEVICE_SHIFT            (11)
>   #define PCI_FUNCTION_SHIFT          (8)
> -#define PCI_ENABLE_BIT              (1 << 31)
> +#define PCI_ENABLE_BIT              (1u << 31)
>   
>   #define PCI_CONF_CLASS_ID          (0x08)
>   #define PCI_CONF_CLASS_ID_SHFT     (16)