Re: [UNIKRAFT PATCH v3 0/3] Add clang support

[Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>]

Hi, Vlad.

This looks good.

There are some warnings that come up when compiling C++ programs due to
compilation flags for lib-compiler-rt:
---
warning: unknown warning option '-Wno-unused-but-set-variable'; did you mean 
'-Wno-unused-const-variable'? [-Wunknown-warning-option]
warning: unknown warning option '-Wno-maybe-uninitialized'; did you mean 
'-Wno-uninitialized'? [-Wunknown-warning-option]
---

But these should be handled as patches to lib-compiler-rt, so I added an
issue on GitHub[1].

[1] https://github.com/unikraft/lib-compiler-rt/issues/1

Reviewed-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>

Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx> writes:
> We add support for clang on Unikraft. This is an
> adapted series of the previous series of patches
> by Alice Suiu.
>
> Changes since v1:
> - Add missing check for lto
> - Fixed typo in have_gcc
>
> Changes since v2:
> - Removed the filter out
> - Added a more flexible approach to select the COMPILER,
>   now we can use .config, environment variable, and
>   command line
> - Rebased on staging
>
> Vlad-Andrei Badoiu (3):
>   build: Option to configure the compiler
>   support/build: Add build functions for clang and gcc check
>   build: Add support for clang
>
>  Makefile                     | 14 ++++++++++++--
>  Makefile.uk                  | 15 +++++++++++----
>  arch/x86/x86_64/Makefile.uk  |  9 ++++++---
>  support/build/Makefile.rules | 12 +++++++++++-
>  4 files changed, 40 insertions(+), 10 deletions(-)