Re: [UNIKRAFT PATCH 1/1] lib/posix-libdl: Add dlvsym stub

[Sharan Santhanam <sharan.santhanam@xxxxxxxxx>]

Hello Vlad,

Thanks for the work!! The patch series introduces the following 
warnings. We should fix them especially the last one before upstreaming it.
`
lib/posix-libdl/stubs.c:71:20: warning: unused parameter ‘handle’ 
[-Wunused-parameter]
 void *dlvsym(void *handle, const char *symbol, const char *version)

lib/posix-libdl/stubs.c:71:40: warning: unused parameter ‘symbol’ 
[-Wunused-parameter]
 void *dlvsym(void *handle, const char *symbol, const char *version)

lib/posix-libdl/stubs.c:71:60: warning: unused parameter ‘version’ 
[-Wunused-parameter]
 void *dlvsym(void *handle, const char *symbol, const char *version)

lib/posix-libdl/stubs.c:73:1: warning: control reaches end of non-void 
function [-Wreturn-type]
`


Thanks & Regards
Sharan

On 11/29/20 8:33 PM, Vlad-Andrei Badoiu wrote:
> Signed-off-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>
> ---
>   lib/posix-libdl/exportsyms.uk   | 3 ++-
>   lib/posix-libdl/include/dlfcn.h | 1 +
>   lib/posix-libdl/stubs.c         | 4 ++++
>   3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/lib/posix-libdl/exportsyms.uk b/lib/posix-libdl/exportsyms.uk
> index 77c7a542..d570a578 100644
> --- a/lib/posix-libdl/exportsyms.uk
> +++ b/lib/posix-libdl/exportsyms.uk
> @@ -3,4 +3,5 @@ dlclose
>   dlsym
>   dlerror
>   dladdr
> -dlinfo
> \ No newline at end of file
> +dlinfo
> +dlvsym
> diff --git a/lib/posix-libdl/include/dlfcn.h b/lib/posix-libdl/include/dlfcn.h
> index 706245a5..6cb6cf52 100644
> --- a/lib/posix-libdl/include/dlfcn.h
> +++ b/lib/posix-libdl/include/dlfcn.h
> @@ -58,6 +58,7 @@ typedef struct {
>   } Dl_info;
>   int dladdr(const void *, Dl_info *);
>   int dlinfo(void *, int, void *);
> +void *dlvsym(void *handle, const char *symbol, const char *version);
>   
>   #ifdef __cplusplus
>   }
> diff --git a/lib/posix-libdl/stubs.c b/lib/posix-libdl/stubs.c
> index dbfac7d1..8f5ee384 100644
> --- a/lib/posix-libdl/stubs.c
> +++ b/lib/posix-libdl/stubs.c
> @@ -67,3 +67,7 @@ int dlinfo(void *handle __unused, int request __unused, void 
> *info __unused)
>   {
>         return 0;
>   }
> +
> +void *dlvsym(void *handle, const char *symbol, const char *version)
> +{
> +}