[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [UNIKRAFT PATCH] lib/nolibc: Fix warning on string.h


  • To: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
  • From: Vlad-Andrei BĂDOIU <vlad_andrei.badoiu@xxxxxx>
  • Date: Thu, 4 Feb 2021 22:56:50 +0200 (EET)
  • Cc: minios-devel <minios-devel@xxxxxxxxxxxxx>
  • Delivery-date: Thu, 04 Feb 2021 20:57:01 +0000
  • Dkim-filter: OpenDKIM Filter v2.10.3 mx.upb.ro D9E76B560181
  • List-id: Mini-os development list <minios-devel.lists.xenproject.org>
  • Thread-index: 8Z6+5zu3z0JDpCTJwB4fVBNqC7MNcg==
  • Thread-topic: lib/nolibc: Fix warning on string.h

Hi Sharan,

The patch works all right, the warning is no longer there. 
Reviewed-by: Vlad-Andrei Badoiu <vlad_andrei.badoiu@xxxxxx>

----- Original Message -----
From: "Sharan Santhanam" <sharan.santhanam@xxxxxxxxx>
To: "minios-devel" <minios-devel@xxxxxxxxxxxxx>
Cc: "Sharan Santhanam" <sharan.santhanam@xxxxxxxxx>
Sent: Thursday, February 4, 2021 10:09:10 PM
Subject: [UNIKRAFT PATCH] lib/nolibc: Fix warning on string.h

`strsignal` function can be defined libuksignal library

Signed-off-by: Sharan Santhanam <sharan.santhanam@xxxxxxxxx>
---
 lib/nolibc/include/string.h | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/nolibc/include/string.h b/lib/nolibc/include/string.h
index 090de75..2644aea 100644
--- a/lib/nolibc/include/string.h
+++ b/lib/nolibc/include/string.h
@@ -72,9 +72,7 @@ char *strdup(const char *str);
 char *strerror_r(int errnum, char *buf, size_t buflen);
 char *strerror(int errnum);
 
-#if CONFIG_LIBUKSIGNAL
 char *strsignal(int sig);
-#endif /* CONFIG_LIBUKSIGNAL */
 
 
 #ifdef __cplusplus
-- 
2.7.4



 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.