Re: [UNIKRAFT PATCH 5/8] Correct license headers introduced by UPB

[Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>]

Yup, I already discussed with Vlad Bădoiu. All is OK.

Razvan

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:
> Hi Razvan,
>
> as discussed offline, I will add a note to your `reviewed-by` tag that
> says that you did it `on behalf of` Vlad-Andrei BĂDOIU who gave the
> agreement to you.
>
> Thanks,
>
> Simon
>
> On 10.03.21 07:37, Razvan Deaconescu wrote:
>> This is OK from UPB's side.
>>
>> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>
>>
>> Razvan
>>
>> Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:
>>> This commit removes the additional clause
>>> "THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY"
>>> from BSD license headers that got introduced by mistake
>>> by Vlad-Andrei BĂDOIU with the following commits:
>>>   d2967b3b1 - lib/ukswrand: Adapt the library to work with multiple 
>>> algorithms
>>>   9bb9a617d - lib/ukswrand: Add ChaCha algorithm
>>>   8c5e2b4bb - lib/ukswrand: Add /dev/random and /dev/urandom
>>>   2784ae201 - lib/nolibc: Add pwd.h
>>>   19ebca61d - include/uk: Add page.h
>>>   8c9cd0ec9 - lib/uksysinfo: Introduce uksysinfo library
>>>   3a39d50dd - plat/*: Introduce unikraft internal constructors
>>>   200037918 - lib/nolibc: Add utsname.h
>>>
>>> On the one hand, this additional clause is redundant because
>>> the BSD license already states that it must remain and the
>>> copyright notice must be kept.
>>> On the other hand, the clause freezes the file header
>>> and prohibits future contributors from extending the
>>> copyright notice for their contributions. This additional
>>> clause is not part of the official BSD 3-clause.
>>>
>>> The original author consents to the change with a `Signed-off-by`
>>> or `Reviewed-by` tag to this commit.
>>>
>>> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
>>> ---
>>>   include/uk/ctors.h                      | 2 --
>>>   include/uk/page.h                       | 2 --
>>>   lib/nolibc/include/pwd.h                | 2 --
>>>   lib/posix-sysinfo/include/sys/utsname.h | 2 --
>>>   lib/posix-sysinfo/sysinfo.c             | 2 --
>>>   lib/ukswrand/chacha.c                   | 2 --
>>>   lib/ukswrand/dev.c                      | 2 --
>>>   lib/ukswrand/swrand.c                   | 2 --
>>>   8 files changed, 16 deletions(-)
>>>
>>> diff --git a/include/uk/ctors.h b/include/uk/ctors.h
>>> index 9c87b53f7..247c3cbdc 100644
>>> --- a/include/uk/ctors.h
>>> +++ b/include/uk/ctors.h
>>> @@ -30,8 +30,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #ifndef __UK_CTORS_H__
>>> diff --git a/include/uk/page.h b/include/uk/page.h
>>> index a9262635a..16f3fc4e7 100644
>>> --- a/include/uk/page.h
>>> +++ b/include/uk/page.h
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #ifndef __UK_PAGE_H__
>>> diff --git a/lib/nolibc/include/pwd.h b/lib/nolibc/include/pwd.h
>>> index 4d81a4324..8a80ee53d 100644
>>> --- a/lib/nolibc/include/pwd.h
>>> +++ b/lib/nolibc/include/pwd.h
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #ifndef __PWD_H__
>>> diff --git a/lib/posix-sysinfo/include/sys/utsname.h 
>>> b/lib/posix-sysinfo/include/sys/utsname.h
>>> index 25baf2fff..d3973c3de 100644
>>> --- a/lib/posix-sysinfo/include/sys/utsname.h
>>> +++ b/lib/posix-sysinfo/include/sys/utsname.h
>>> @@ -29,8 +29,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #ifndef __SYS_UTSNAME_H__
>>> diff --git a/lib/posix-sysinfo/sysinfo.c b/lib/posix-sysinfo/sysinfo.c
>>> index 922f3b141..f57914b68 100644
>>> --- a/lib/posix-sysinfo/sysinfo.c
>>> +++ b/lib/posix-sysinfo/sysinfo.c
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #include <stddef.h>
>>> diff --git a/lib/ukswrand/chacha.c b/lib/ukswrand/chacha.c
>>> index 0ce1b992a..ae1185924 100644
>>> --- a/lib/ukswrand/chacha.c
>>> +++ b/lib/ukswrand/chacha.c
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #include <string.h>
>>> diff --git a/lib/ukswrand/dev.c b/lib/ukswrand/dev.c
>>> index 40a14268c..fbd447d1b 100644
>>> --- a/lib/ukswrand/dev.c
>>> +++ b/lib/ukswrand/dev.c
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>     #include <stdlib.h>
>>> diff --git a/lib/ukswrand/swrand.c b/lib/ukswrand/swrand.c
>>> index ded57bb58..37af27f75 100644
>>> --- a/lib/ukswrand/swrand.c
>>> +++ b/lib/ukswrand/swrand.c
>>> @@ -26,8 +26,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>   #include <string.h>
>>>   #include <uk/swrand.h>