Re: [UNIKRAFT PATCH 6/8] Correct license headers introduced by UPB

[Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>]

Yup, I already discussed with Razvan Cojocaru. All is OK.

Razvan

Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:
> Hi Razvan,
>
> as discussed offline, I will add a note to your `reviewed-by` tag that
> says that you did it `on behalf of` Razvan Cojocaru who gave the
> agreement to you.
>
> Thanks,
>
> Simon
>
> On 10.03.21 07:36, Razvan Deaconescu wrote:
>> This is OK from UPB's side.
>>
>> Reviewed-by: Razvan Deaconescu <razvan.deaconescu@xxxxxxxxx>
>>
>> Razvan
>>
>> Simon Kuenzer <simon.kuenzer@xxxxxxxxx> writes:
>>> This commit removes the additional clause
>>> "THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY"
>>> from BSD license headers that got introduced by mistake
>>> by Razvan Cojocaru with the following commit:
>>>   63fac86c7 - lib/uknetdev: Netdev registration
>>>
>>> On the one hand, this additional clause is redundant because
>>> the BSD license already states that it must remain and the
>>> copyright notice must be kept.
>>> On the other hand, the clause freezes the file header
>>> and prohibits future contributors from extending the
>>> copyright notice for their contributions. This additional
>>> clause is not part of the official BSD 3-clause.
>>>
>>> The original author consents to the change with a `Signed-off-by`
>>> or `Reviewed-by` tag to this commit.
>>>
>>> Signed-off-by: Simon Kuenzer <simon.kuenzer@xxxxxxxxx>
>>> ---
>>>   lib/uknetdev/include/uk/netdev.h        | 2 --
>>>   lib/uknetdev/include/uk/netdev_core.h   | 2 --
>>>   lib/uknetdev/include/uk/netdev_driver.h | 2 --
>>>   lib/uknetdev/netdev.c                   | 2 --
>>>   4 files changed, 8 deletions(-)
>>>
>>> diff --git a/lib/uknetdev/include/uk/netdev.h 
>>> b/lib/uknetdev/include/uk/netdev.h
>>> index 74a04ad73..b3ee666b3 100644
>>> --- a/lib/uknetdev/include/uk/netdev.h
>>> +++ b/lib/uknetdev/include/uk/netdev.h
>>> @@ -30,8 +30,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>   /* Derived from DPDK rte_ethdev_core.h - DPDK.org 18.02.2 */
>>>   #ifndef __UK_NETDEV__
>>> diff --git a/lib/uknetdev/include/uk/netdev_core.h 
>>> b/lib/uknetdev/include/uk/netdev_core.h
>>> index df6ceebfd..e8ebaae8b 100644
>>> --- a/lib/uknetdev/include/uk/netdev_core.h
>>> +++ b/lib/uknetdev/include/uk/netdev_core.h
>>> @@ -30,8 +30,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>   /* Derived from DPDK rte_ethdev_core.h - DPDK.org 18.02.2 */
>>>   #ifndef __UK_NETDEV_CORE__
>>> diff --git a/lib/uknetdev/include/uk/netdev_driver.h 
>>> b/lib/uknetdev/include/uk/netdev_driver.h
>>> index 6033f6201..96408580b 100644
>>> --- a/lib/uknetdev/include/uk/netdev_driver.h
>>> +++ b/lib/uknetdev/include/uk/netdev_driver.h
>>> @@ -28,8 +28,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>   #ifndef __UK_NETDEV_DRIVER__
>>>   #define __UK_NETDEV_DRIVER__
>>> diff --git a/lib/uknetdev/netdev.c b/lib/uknetdev/netdev.c
>>> index 87322c7f4..cb02b06a5 100644
>>> --- a/lib/uknetdev/netdev.c
>>> +++ b/lib/uknetdev/netdev.c
>>> @@ -30,8 +30,6 @@
>>>    * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
>>>    * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF 
>>> THE
>>>    * POSSIBILITY OF SUCH DAMAGE.
>>> - *
>>> - * THIS HEADER MAY NOT BE EXTRACTED OR MODIFIED IN ANY WAY.
>>>    */
>>>   #define _GNU_SOURCE /* for asprintf() */
>>>   #include <stdio.h>