RE: [RFCv4,07/35] plat/ofw: Export fdt_find_irq_parent_offset

[Justin He <Justin.He@xxxxxxx>]

Hi Razvan

> -----Original Message-----
> From: Razvan Virtan <virtanrazvan@xxxxxxxxx>
> Sent: Friday, April 16, 2021 10:34 PM
> To: Justin He <Justin.He@xxxxxxx>
> Cc: minios-devel@xxxxxxxxxxxxx
> Subject: Re: [RFCv4,07/35] plat/ofw: Export fdt_find_irq_parent_offset
>
> Hi, Justin.
> I think the description for fdt_find_irq_parent_offset provided in the
> header file is wrong, since it describes `fdt_node_offset_by_phandle()`
> from `libfdt.h` instead of `fdt_find_irq_parent_offset()`.
>
> /**
>
> The second argument should be something like:
> @offset: offset of the node whose irq parent to find
>
>  * fdt_find_irq_parent_offset - find the irq parent offset
>  * @fdt: pointer to the device tree blob
>  * @phandle: phandle value
>  *
>
> I think the detailed description below should be removed or replaced with
> one
> that describes this function.
Indeed, sorry for the mistake.


--
Cheers,
Justin (Jia He)


>
>  * fdt_node_offset_by_phandle() returns the offset of the node
>  * which has the given phandle value.  If there is more than one node
>  * in the tree with the given phandle (an invalid tree), results are
>  * undefined.
>  *
>  * returns:
>  *    structure block offset of the located node (>= 0), on success
>  *    -FDT_ERR_NOTFOUND, no node with that phandle exists
>  *    -FDT_ERR_BADPHANDLE, given phandle value was invalid (0 or -1)
>  *    -FDT_ERR_BADMAGIC,
>  *    -FDT_ERR_BADVERSION,
>  *    -FDT_ERR_BADSTATE,
>  *    -FDT_ERR_BADSTRUCTURE, standard meanings
>  */
> int fdt_find_irq_parent_offset(const void *fdt, int offset);
>
>
> Reviewed-by: Razvan Virtan <virtanrazvan@xxxxxxxxx>
IMPORTANT NOTICE: The contents of this email and any attachments are 
confidential and may also be privileged. If you are not the intended recipient, 
please notify the sender immediately and do not disclose the contents to any 
other person, use it for any purpose, or store or copy the information in any 
medium. Thank you.