Re: [External] [PATCH] lib/vfscore: Correct the macro name of UK_LIBC_SYSCALLS

["Jung, Alexander (Student)" <a.jung@xxxxxxxxxxxxxxx>]

Hi Justin,

Thanks for this fix! :D  Turns out this “spelling mistake” occurs in several 
other places too.  For this reason we’ve created a PR on Github[0] with general 
fix and included your patch in the same series.  

Also, I couldn’t see your email turn up on patchwork for some reason — not sure 
why it wasn’t caught.  Anyway, with the migration to Github currently on-going, 
can you please submit new features/fixes as PRs to the Unikraft repo? :)

Thanks and all the best,

Alexander Jung,

Ph.D Student,
Networking & Systems Research Group, 
Lancaster University
net.scc.lancs.ac.uk

F4D5 C6B6 9139 4942 9407  7F54 ED30 1A8A 1763 1B62

[0]: https://github.com/unikraft/unikraft/pull/204

> On 13. May 2021, at 09:28, Jia He <justin.he@xxxxxxx> wrote:
> 
> This email originated outside the University. Check before clicking links or 
> attachments.
> 
> Correct the name from UK_LIBC_SYSCALL to UK_LIBC_SYSCALLS
> 
> Otherwise the linking will report:
> libs/newlib/musl-imported/src/termios/tcsetattr.c:35:
> undefined reference to `ioctl'
> /bin/ld:
> apps/sqlite/build/sqlite_kvm-x86_64.o: in
> function `tcgetattr':
> libs/newlib/musl-imported/src/termios/tcgetattr.c:30:
> undefined reference to `ioctl'
> 
> Reported-by: Alexander Jung <a.jung@xxxxxxxxxxx>
> Signed-off-by: Jia He <justin.he@xxxxxxx>
> ---
> lib/vfscore/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/vfscore/main.c b/lib/vfscore/main.c
> index 11bfa93..0ecad74 100644
> --- a/lib/vfscore/main.c
> +++ b/lib/vfscore/main.c
> @@ -673,7 +673,7 @@ out_errno:
>        return -error;
> }
> 
> -#if UK_LIBC_SYSCALL
> +#if UK_LIBC_SYSCALLS
> int ioctl(int fd, unsigned long int request, ...)
> {
>        va_list ap;
> --
> 2.17.1
> 
>