[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/7] Mini-OS: add support for runtime mounts
- To: Juergen Gross <jgross@xxxxxxxx>, minios-devel@xxxxxxxxxxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxxx
- From: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
- Date: Fri, 10 Feb 2023 11:43:45 +0000
- Arc-authentication-results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=citrix.com; dmarc=pass action=none header.from=citrix.com; dkim=pass header.d=citrix.com; arc=none
- Arc-message-signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TamF8SrNO6lCSMT/cBeMvIiv3d8WU5RPQ1qkqPNlfSs=; b=MfUvUlx4CkuvJ2w69ET8IZ+K6ffVRzM4W0iWK7QSuWQz2FpxE2TedVMewHm+toys4mA4o91foIGLHzlBuDgaBRYkKFPzjFDqUpEZDrUzulMYkKHkRKsvxJxfanjZn1BoQTasXJzE0dPXY2PKCGigTmoDGZ74YkzQZx+EKLhp3nzrB2N8482/KK9KJU4Xmywz7DWs7vigJ5CTvpqtDZL3PomQ0AKsevGMN9pA7npgvBUdr+oQH3dw0smYtsKb4Qtxd3rUKSwJQvZqps22TQAw9oNrcSb4Exk2zK7PyOD3yqNGtJOOOIrg81DyqHO7b4PRXs9U4Lfb6Um7FddMAKGuUA==
- Arc-seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jMz4VXTj6Sh5fQCDL5t9rpQCwsjFJIg9S3L9jd6q6ei40AUdYdqxOCTgckcuPon1JApU7T6UE7/4JOLO1TQGQPkc66RCW0NUvYrTTCdfyzEy/Nzfgz8IR8drxOM94rmAogbv4oKkSt+NM3nWw9pw8DB+FxD87bLXvvMAsnkFTi6WIujMdMD7smw0bIIdmzVpFwvyoA53k764I2nYGzVUKF/u9tZQedGNhc0Kz73ayN03bou9j2YcWYHCXZG75aAz35QTJiQWNoeo9Wk2I10L1svSfG6/XlrGMZ/5/vZelOyWFowj4pYSCTn62vYqlV3AEqjt8eH+0ABASycKRzpXMg==
- Authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=citrix.com;
- Cc: samuel.thibault@xxxxxxxxxxxx, wl@xxxxxxx
- Delivery-date: Fri, 10 Feb 2023 11:44:15 +0000
- Ironport-data: A9a23:4gyftqNBVdqE3QHvrR1HlsFynXyQoLVcMsEvi/4bfWQNrUol0zBTx mNMWmqOb6yNN2fxKop+YY2y9kMBvJHcmN9lGgto+SlhQUwRpJueD7x1DKtS0wC6dZSfER09v 63yTvGacajYm1eF/k/F3oDJ9CU6jufQAOKnUoYoAwgpLSd8UiAtlBl/rOAwh49skLCRDhiE/ Nj/uKUzAnf8s9JPGj9Suv3rRC9H5qyo42tC5wRmPJingXeF/5UrJMNHTU2OByOQrrl8RoaSW +vFxbelyWLVlz9F5gSNy+uTnuUiG9Y+DCDW4pZkc/HKbitq/0Te5p0TJvsEAXq7vh3S9zxHJ HehgrTrIeshFvWkdO3wyHC0GQkmVUFN0OevzXRSLaV/ZqAJGpfh66wGMa04AWEX0vl4IUhRy u4CEREud1ediOeznOnqVPY506zPLOGzVG8ekldJ6GiASN0BGNXESaiM4sJE1jAtgMwIBezZe 8cSdTtoalLHfgFLPVAUTpk5mY9EhFGmK2Ee9A3T+PRxujaCpOBy+OGF3N79U9qGX8hK2G2fo XrL5T/RCRAGLt2PjzGC9xpAg8eewHKiANhNS9VU8NZ3uxqC2FAXFScwD3enkfSTs2OCCv9Qf hl8Fi0G6PJaGFaQZtvyRRqju1afowURHdFXFoUS7QCLy63PpgqUGGUAZjpAc8A98t87QyQw0 V2ElM+vAiZg2JWFRHTY+rqKoDeaPSkOMXREdSICVREC4dTovMc0lB2nZs1qFbO4ipvpGTD6y i2OsAAzga5Wid8M0eO851+vqy2ojojESEgy/Aq/Y46+xgZwZYrgbIvx71HetK9ENNzAEAjHu 2UYkc+D6uxIFYuKiCGGXOQKGveu+uqBNzrfx1VoGvHN6giQxpJqRqgIiBkWGaujGpxdEdM1S Cc/YT9s2aI=
- Ironport-hdrordr: A9a23:pCmEYaOBKDoR+8BcTuejsMiBIKoaSvp037B87TEKdfVwSL3gqy nIpoV86faUskd3ZJhEo7q90ca7MBDhHPJOgbX5Xo3SODUO2lHYTr2KtrGSuwEIcheWnoVgPM xbAs1D4bPLbGRSvILT/BS/CNo4xcnvytHSuQ4c9RtQpMNRBp2IIz0XNu9TKCNLeDU=
- List-id: Mini-os development list <minios-devel.lists.xenproject.org>
On 10/02/2023 10:46 am, Juergen Gross wrote:
> diff --git a/lib/sys.c b/lib/sys.c
> index 2f33c937..dc8a8c69 100644
> --- a/lib/sys.c
> +++ b/lib/sys.c
> @@ -339,7 +339,14 @@ static int open_mem(struct mount_point *mnt, const char
> *pathname, int flags,
> return fd;
> }
>
> -static struct mount_point mount_points[] = {
> +#ifdef CONFIG_CONSFRONT
> +#define STATIC_MNTS 4
> +#else
> +#define STATIC_MNTS 2
> +#endif
This ought to be
#define STATIC_MNTS (2 + (IS_ENABLED(CONFIG_CONSFRONT) * 2))
because it shows where the parts come from, and is much cleaner to add a
3rd one to in due course.
That said, it would be simpler to just have a total mounts set at 16 or
so? Does a difference of two dynamic mounts depending on CONSFRONT
actually matter?
~Andrew
|
