Re: [PATCH 2/3] mini-os: mm: switch need_pgt() to use walk_pt()

[Jürgen Groß <jgross@xxxxxxxx>]

On 31.07.24 23:27, Samuel Thibault wrote:
> Hello,
>
> Juergen Gross, le mer. 31 juil. 2024 15:00:25 +0200, a ecrit:
> > -pgentry_t *need_pgt(unsigned long va)
> > +static int need_pgt_func(unsigned long va, unsigned int lvl, bool is_leaf,
> > +                         pgentry_t *pte, void *par)
> >   {
> [...]
> > +    if ( lvl == L1_FRAME || (*pte & _PAGE_PRESENT) )
> Did you mean (*pte & _PAGE_PSE)?
No. I want to bail out if the PTE does not require a page table to be
added to it. This is the case if the PTE is valid or if it is at the
lowest page table level already.

An invalid PTE with PSE set is still invalid, so the PSE bit has no
real meaning.


Juergen