Re: [MirageOS-devel] Logging (was: test, quality, tcpip)

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

On 12 May 2015, at 16:47, Richard Mortier <richard.mortier@xxxxxxxxxxxx> wrote:
> 
> On 12 May 2015 at 16:56, Anil Madhavapeddy <anil@xxxxxxxxxx> wrote:
>> - Ban all uses of console logging from all of our protocol libraries.  We 
>> should *never* be logging directly to the console, as this is both a 
>> denial-of-service opportunity and something that is very difficult to 
>> aggregate and track.
>> 
> 
> Presumably this is simply achieved by ceasing to pass in the CONSOLE
> signature anywhere, and then twiddling things until they compile? :)

Not that easy unfortunately -- the console logging mostly happens via
direct calls to Printf.[e]printf and print_endline/prerr_endline.

Threading through a ubiquitous logger to these interfaces would give us
the ability to easily call an alternative function, but at the cost
of some significant revving of interfaces.  Worth doing, but only 
worth doing so once...

-anil
_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/mirageos-devel