Re: [MirageOS-devel] adding `replace_listener` function to Mirage_net.S

[Anil Madhavapeddy <anil@xxxxxxxxxx>]

> On 18 Jun 2019, at 19:08, Hannes Mehnert <hannes@xxxxxxxxxxx> wrote:
> 
> Hello,
> 
> On 18/06/2019 17:33, Mindy Preston wrote:
>> In mirage_net.mli, the documentation for `val listen` says:
>> "this function can be stopped by calling disconnect in the device layer".
>> 
>> This is the only method mentioned to stop the call to `listen`. There
>> isn't any API call for replacing the callback established in `listen`. 
>> In mirage-vnetif, `disconnect` just stops the listener, and we can
>> continue to use the device after. This does not work for mirage-net-xen
>> (and maybe solo5), because disconnect cleans up the interface and we can
>> not continue using it.
> 
> As far as I can read both mirage-net-unix and mirage-net-solo5 are fine
> with sequences of connect followed by disconnect calls; maybe we should
> revise the documentation in mirage-net (that connect ; disconnect ;
> connect should work fine) and adapt mirage-net-xen to follow that behaviour?

Agreed; fixing mirage-net-xen sounds better here. It might become a
new interface (with a different vif number), but that shouldn't matter
to the unikernel I think.

regards,
Anil


_______________________________________________
MirageOS-devel mailing list
MirageOS-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/mirageos-devel