|
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index] [xen-4.8-testing test] 124783: trouble: blocked/broken/preparing/queued
flight 124783 xen-4.8-testing running [real] http://logs.test-lab.xenproject.org/osstest/logs/124783/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 <job status> broken build-amd64-xsm <job status> broken build-i386 <job status> broken build-amd64-xtf <job status> broken build-i386-xsm <job status> broken build-i386-xsm 4 host-install(4) broken REGR. vs. 124351 build-amd64-xsm 4 host-install(4) broken REGR. vs. 124351 build-amd64-xtf 4 host-install(4) broken REGR. vs. 124351 build-amd64 4 host-install(4) broken REGR. vs. 124351 build-i386 4 host-install(4) broken REGR. vs. 124351 test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm <none executed> queued test-xtf-amd64-amd64-3 <none executed> queued test-amd64-amd64-pair <none executed> queued test-amd64-i386-libvirt-xsm <none executed> queued test-amd64-i386-xl-qemuu-debianhvm-amd64 <none executed> queued test-amd64-amd64-xl-qemuu-ovmf-amd64 <none executed> queued test-amd64-amd64-xl-qemut-win7-amd64 <none executed> queued test-amd64-amd64-xl-rtds <none executed> queued test-amd64-i386-qemut-rhel6hvm-intel <none executed> queued test-amd64-amd64-i386-pvgrub <none executed> queued test-amd64-amd64-xl-qemut-debianhvm-amd64 <none executed> queued test-amd64-amd64-xl-qemuu-win7-amd64 <none executed> queued test-amd64-i386-xl-qemut-win7-amd64 <none executed> queued test-amd64-amd64-xl-qemuu-win10-i386 <none executed> queued test-amd64-i386-xl-qemuu-win10-i386 <none executed> queued test-arm64-arm64-xl-xsm <none executed> queued test-amd64-amd64-libvirt <none executed> queued test-armhf-armhf-xl-credit2 <none executed> queued test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow <none executed> queued test-amd64-i386-xl-shadow <none executed> queued test-amd64-i386-livepatch <none executed> queued test-amd64-i386-rumprun-i386 <none executed> queued test-amd64-amd64-xl-xsm <none executed> queued test-armhf-armhf-xl-rtds <none executed> queued test-amd64-amd64-libvirt-vhd <none executed> queued test-amd64-amd64-amd64-pvgrub <none executed> queued test-amd64-i386-xl-qemuu-win7-amd64 <none executed> queued build-arm64-libvirt <none executed> queued test-amd64-amd64-rumprun-amd64 <none executed> queued test-armhf-armhf-libvirt-raw <none executed> queued test-amd64-i386-qemuu-rhel6hvm-amd <none executed> queued test-amd64-i386-qemut-rhel6hvm-amd <none executed> queued test-xtf-amd64-amd64-2 <none executed> queued test-amd64-amd64-xl <none executed> queued test-amd64-amd64-xl-qemut-win10-i386 <none executed> queued test-amd64-i386-libvirt-pair <none executed> queued test-amd64-i386-libvirt <none executed> queued test-amd64-i386-xl-qemuu-ws16-amd64 <none executed> queued test-amd64-amd64-xl-qcow2 <none executed> queued test-amd64-amd64-xl-credit2 <none executed> queued test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm <none executed> queued test-amd64-i386-xl-qemut-debianhvm-amd64 <none executed> queued test-amd64-i386-xl-qemut-ws16-amd64 <none executed> queued test-amd64-i386-freebsd10-amd64 <none executed> queued test-amd64-amd64-xl-multivcpu <none executed> queued test-arm64-arm64-libvirt-xsm <none executed> queued test-amd64-i386-xl <none executed> queued test-armhf-armhf-xl <none executed> queued test-amd64-amd64-qemuu-nested-amd <none executed> queued test-amd64-amd64-xl-qemuu-debianhvm-amd64 <none executed> queued test-amd64-amd64-livepatch <none executed> queued test-amd64-amd64-qemuu-nested-intel <none executed> queued test-amd64-i386-pair <none executed> queued test-amd64-i386-qemuu-rhel6hvm-intel <none executed> queued test-amd64-amd64-pygrub <none executed> queued build-armhf-libvirt <none executed> queued test-arm64-arm64-xl-credit2 <none executed> queued test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm <none executed> queued test-amd64-amd64-migrupgrade <none executed> queued test-armhf-armhf-libvirt-xsm <none executed> queued test-amd64-i386-xl-qemut-win10-i386 <none executed> queued test-armhf-armhf-xl-xsm <none executed> queued test-amd64-amd64-libvirt-xsm <none executed> queued test-armhf-armhf-xl-cubietruck <none executed> queued test-xtf-amd64-amd64-5 <none executed> queued test-armhf-armhf-xl-arndale <none executed> queued test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm <none executed> queued test-xtf-amd64-amd64-4 <none executed> queued test-amd64-i386-xl-qemut-debianhvm-amd64-xsm <none executed> queued test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm <none executed> queued test-amd64-i386-migrupgrade <none executed> queued test-amd64-i386-xl-xsm <none executed> queued test-arm64-arm64-xl <none executed> queued test-amd64-i386-freebsd10-i386 <none executed> queued test-amd64-amd64-xl-shadow <none executed> queued test-xtf-amd64-amd64-1 <none executed> queued test-amd64-amd64-xl-qemut-ws16-amd64 <none executed> queued test-armhf-armhf-libvirt <none executed> queued test-armhf-armhf-xl-vhd <none executed> queued test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm <none executed> queued test-amd64-amd64-xl-qemuu-ws16-amd64 <none executed> queued test-amd64-amd64-libvirt-pair <none executed> queued test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow <none executed> queued test-amd64-i386-xl-qemuu-ovmf-amd64 <none executed> queued test-armhf-armhf-xl-multivcpu <none executed> queued test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm <none executed> queued test-amd64-i386-xl-raw <none executed> queued build-arm64-xsm 2 hosts-allocate running build-armhf-pvops 2 hosts-allocate running build-i386-pvops 2 hosts-allocate running build-armhf 2 hosts-allocate running build-armhf-xsm 2 hosts-allocate running build-arm64-pvops 2 hosts-allocate running build-i386-prev 2 hosts-allocate running build-amd64-pvops 2 hosts-allocate running build-arm64 2 hosts-allocate running build-amd64-prev 2 hosts-allocate running Tests which did not succeed, but are not blocking: build-amd64-rumprun 1 build-check(1) blocked n/a build-amd64-libvirt 1 build-check(1) blocked n/a build-i386-rumprun 1 build-check(1) blocked n/a build-i386-libvirt 1 build-check(1) blocked n/a version targeted for testing: xen e39ff386f626ba44f8a9a9608d8f5f13ff7945ef baseline version: xen c1aaad5627448a84c4e49304d89b11a8e6f588e7 Last test of basis 124351 2018-06-18 11:30:45 Z 10 days Testing same since (not found) 0 attempts ------------------------------------------------------------ People who touched revisions under test: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> Jan Beulich <jbeulich@xxxxxxxx> Juergen Gross <jgross@xxxxxxxx> jobs: build-amd64-xsm broken build-arm64-xsm preparing build-armhf-xsm preparing build-i386-xsm broken build-amd64-xtf broken build-amd64 broken build-arm64 preparing build-armhf preparing build-i386 broken build-amd64-libvirt blocked build-arm64-libvirt queued build-armhf-libvirt queued build-i386-libvirt blocked build-amd64-prev preparing build-i386-prev preparing build-amd64-pvops preparing build-arm64-pvops preparing build-armhf-pvops preparing build-i386-pvops preparing build-amd64-rumprun blocked build-i386-rumprun blocked test-xtf-amd64-amd64-1 queued test-xtf-amd64-amd64-2 queued test-xtf-amd64-amd64-3 queued test-xtf-amd64-amd64-4 queued test-xtf-amd64-amd64-5 queued test-amd64-amd64-xl queued test-arm64-arm64-xl queued test-armhf-armhf-xl queued test-amd64-i386-xl queued test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm queued test-amd64-i386-xl-qemut-debianhvm-amd64-xsm queued test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm queued test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm queued test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm queued test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm queued test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm queued test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm queued test-amd64-amd64-libvirt-xsm queued test-arm64-arm64-libvirt-xsm queued test-armhf-armhf-libvirt-xsm queued test-amd64-i386-libvirt-xsm queued test-amd64-amd64-xl-xsm queued test-arm64-arm64-xl-xsm queued test-armhf-armhf-xl-xsm queued test-amd64-i386-xl-xsm queued test-amd64-amd64-qemuu-nested-amd queued test-amd64-i386-qemut-rhel6hvm-amd queued test-amd64-i386-qemuu-rhel6hvm-amd queued test-amd64-amd64-xl-qemut-debianhvm-amd64 queued test-amd64-i386-xl-qemut-debianhvm-amd64 queued test-amd64-amd64-xl-qemuu-debianhvm-amd64 queued test-amd64-i386-xl-qemuu-debianhvm-amd64 queued test-amd64-i386-freebsd10-amd64 queued test-amd64-amd64-xl-qemuu-ovmf-amd64 queued test-amd64-i386-xl-qemuu-ovmf-amd64 queued test-amd64-amd64-rumprun-amd64 queued test-amd64-amd64-xl-qemut-win7-amd64 queued test-amd64-i386-xl-qemut-win7-amd64 queued test-amd64-amd64-xl-qemuu-win7-amd64 queued test-amd64-i386-xl-qemuu-win7-amd64 queued test-amd64-amd64-xl-qemut-ws16-amd64 queued test-amd64-i386-xl-qemut-ws16-amd64 queued test-amd64-amd64-xl-qemuu-ws16-amd64 queued test-amd64-i386-xl-qemuu-ws16-amd64 queued test-armhf-armhf-xl-arndale queued test-amd64-amd64-xl-credit2 queued test-arm64-arm64-xl-credit2 queued test-armhf-armhf-xl-credit2 queued test-armhf-armhf-xl-cubietruck queued test-amd64-i386-freebsd10-i386 queued test-amd64-i386-rumprun-i386 queued test-amd64-amd64-xl-qemut-win10-i386 queued test-amd64-i386-xl-qemut-win10-i386 queued test-amd64-amd64-xl-qemuu-win10-i386 queued test-amd64-i386-xl-qemuu-win10-i386 queued test-amd64-amd64-qemuu-nested-intel queued test-amd64-i386-qemut-rhel6hvm-intel queued test-amd64-i386-qemuu-rhel6hvm-intel queued test-amd64-amd64-libvirt queued test-armhf-armhf-libvirt queued test-amd64-i386-libvirt queued test-amd64-amd64-livepatch queued test-amd64-i386-livepatch queued test-amd64-amd64-migrupgrade queued test-amd64-i386-migrupgrade queued test-amd64-amd64-xl-multivcpu queued test-armhf-armhf-xl-multivcpu queued test-amd64-amd64-pair queued test-amd64-i386-pair queued test-amd64-amd64-libvirt-pair queued test-amd64-i386-libvirt-pair queued test-amd64-amd64-amd64-pvgrub queued test-amd64-amd64-i386-pvgrub queued test-amd64-amd64-pygrub queued test-amd64-amd64-xl-qcow2 queued test-armhf-armhf-libvirt-raw queued test-amd64-i386-xl-raw queued test-amd64-amd64-xl-rtds queued test-armhf-armhf-xl-rtds queued test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow queued test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow queued test-amd64-amd64-xl-shadow queued test-amd64-i386-xl-shadow queued test-amd64-amd64-libvirt-vhd queued test-armhf-armhf-xl-vhd queued ------------------------------------------------------------ sg-report-flight on osstest.test-lab.xenproject.org logs: /home/logs/logs images: /home/logs/images Logs, config files, etc. are available at http://logs.test-lab.xenproject.org/osstest/logs Explanation of these reports, and of osstest in general, is at http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README.email;hb=master http://xenbits.xen.org/gitweb/?p=osstest.git;a=blob;f=README;hb=master Test harness code can be found at http://xenbits.xen.org/gitweb?p=osstest.git;a=summary broken-job test-amd64-i386-xl-qemut-stubdom-debianhvm-amd64-xsm queued broken-job test-xtf-amd64-amd64-3 queued broken-job test-amd64-amd64-pair queued broken-job test-amd64-i386-libvirt-xsm queued broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64 queued broken-job test-amd64-amd64-xl-qemuu-ovmf-amd64 queued broken-job test-amd64-amd64-xl-qemut-win7-amd64 queued broken-job test-amd64-amd64-xl-rtds queued broken-job test-amd64-i386-qemut-rhel6hvm-intel queued broken-job test-amd64-amd64-i386-pvgrub queued broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64 queued broken-job test-amd64-amd64-xl-qemuu-win7-amd64 queued broken-job test-amd64-i386-xl-qemut-win7-amd64 queued broken-job test-amd64-amd64-xl-qemuu-win10-i386 queued broken-job test-amd64-i386-xl-qemuu-win10-i386 queued broken-job test-arm64-arm64-xl-xsm queued broken-job test-amd64-amd64-libvirt queued broken-job test-armhf-armhf-xl-credit2 queued broken-job test-amd64-amd64-xl-qemuu-debianhvm-amd64-shadow queued broken-job test-amd64-i386-xl-shadow queued broken-job test-amd64-i386-livepatch queued broken-job test-amd64-i386-rumprun-i386 queued broken-job test-amd64-amd64-xl-xsm queued broken-job test-armhf-armhf-xl-rtds queued broken-job test-amd64-amd64-libvirt-vhd queued broken-job build-amd64 broken broken-job test-amd64-amd64-amd64-pvgrub queued broken-job test-amd64-i386-xl-qemuu-win7-amd64 queued broken-job build-arm64-libvirt queued broken-job test-amd64-amd64-rumprun-amd64 queued broken-job test-armhf-armhf-libvirt-raw queued broken-job test-amd64-i386-qemuu-rhel6hvm-amd queued broken-job test-amd64-i386-qemut-rhel6hvm-amd queued broken-job build-amd64-xsm broken broken-job test-xtf-amd64-amd64-2 queued broken-job test-amd64-amd64-xl queued broken-job test-amd64-amd64-xl-qemut-win10-i386 queued broken-job test-amd64-i386-libvirt-pair queued broken-job test-amd64-i386-libvirt queued broken-job test-amd64-i386-xl-qemuu-ws16-amd64 queued broken-job test-amd64-amd64-xl-qcow2 queued broken-job test-amd64-amd64-xl-credit2 queued broken-job test-amd64-amd64-xl-qemut-debianhvm-amd64-xsm queued broken-job test-amd64-i386-xl-qemut-debianhvm-amd64 queued broken-job test-amd64-i386-xl-qemut-ws16-amd64 queued broken-job test-amd64-i386-freebsd10-amd64 queued broken-job test-amd64-amd64-xl-multivcpu queued broken-job test-arm64-arm64-libvirt-xsm queued broken-job test-amd64-i386-xl queued broken-job test-armhf-armhf-xl queued broken-job test-amd64-amd64-qemuu-nested-amd queued broken-job test-amd64-amd64-xl-qemuu-debianhvm-amd64 queued broken-job test-amd64-amd64-livepatch queued broken-job test-amd64-amd64-qemuu-nested-intel queued broken-job test-amd64-i386-pair queued broken-job build-i386 broken broken-job test-amd64-i386-qemuu-rhel6hvm-intel queued broken-job test-amd64-amd64-pygrub queued broken-job build-armhf-libvirt queued broken-job test-arm64-arm64-xl-credit2 queued broken-job test-amd64-i386-libvirt-qemuu-debianhvm-amd64-xsm queued broken-job test-amd64-amd64-migrupgrade queued broken-job test-armhf-armhf-libvirt-xsm queued broken-job test-amd64-i386-xl-qemut-win10-i386 queued broken-job test-armhf-armhf-xl-xsm queued broken-job test-amd64-amd64-libvirt-xsm queued broken-job test-armhf-armhf-xl-cubietruck queued broken-job test-xtf-amd64-amd64-5 queued broken-job test-armhf-armhf-xl-arndale queued broken-job test-amd64-amd64-libvirt-qemuu-debianhvm-amd64-xsm queued broken-job test-xtf-amd64-amd64-4 queued broken-job test-amd64-i386-xl-qemut-debianhvm-amd64-xsm queued broken-job test-amd64-amd64-xl-qemuu-debianhvm-amd64-xsm queued broken-job test-amd64-i386-migrupgrade queued broken-job test-amd64-i386-xl-xsm queued broken-job test-arm64-arm64-xl queued broken-job test-amd64-i386-freebsd10-i386 queued broken-job test-amd64-amd64-xl-shadow queued broken-job test-xtf-amd64-amd64-1 queued broken-job test-amd64-amd64-xl-qemut-ws16-amd64 queued broken-job test-armhf-armhf-libvirt queued broken-job build-amd64-xtf broken broken-job test-armhf-armhf-xl-vhd queued broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-xsm queued broken-job test-amd64-amd64-xl-qemuu-ws16-amd64 queued broken-job test-amd64-amd64-libvirt-pair queued broken-job test-amd64-i386-xl-qemuu-debianhvm-amd64-shadow queued broken-job test-amd64-i386-xl-qemuu-ovmf-amd64 queued broken-job test-armhf-armhf-xl-multivcpu queued broken-job build-i386-xsm broken broken-job test-amd64-amd64-xl-qemut-stubdom-debianhvm-amd64-xsm queued broken-job test-amd64-i386-xl-raw queued broken-step build-i386-xsm host-install(4) broken-step build-amd64-xsm host-install(4) broken-step build-amd64-xtf host-install(4) broken-step build-amd64 host-install(4) broken-step build-i386 host-install(4) Not pushing. ------------------------------------------------------------ commit e39ff386f626ba44f8a9a9608d8f5f13ff7945ef Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:23:33 2018 +0200 x86/HVM: don't cause #NM to be raised in Xen The changes for XSA-267 did not touch management of CR0.TS for HVM guests. In fully eager mode this bit should never be set when respective vCPU-s are active, or else hvmemul_get_fpu() might leave it wrongly set, leading to #NM in hypervisor context. {svm,vmx}_enter() and {svm,vmx}_fpu_dirty_intercept() become unreachable this way. Explicit {svm,vmx}_fpu_leave() invocations need to be guarded now. With no CR0.TS management necessary in fully eager mode, there's also no need anymore to intercept #NM. Reported-by: Charles Arnold <carnold@xxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: 488efc29e4e996bb3805c982200f65061390cdce master date: 2018-06-28 09:07:06 +0200 commit 321254a107fe695a84c45acadcec842e36fe8bbf Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Thu Jun 28 11:23:11 2018 +0200 libxl: restore passing "readonly=" to qemu for SCSI disks A read-only check was introduced for XSA-142, commit ef6cb76026 ("libxl: relax readonly check introduced by XSA-142 fix") added the passing of the extra setting, but commit dab0539568 ("Introduce COLO mode and refactor relevant function") dropped the passing of the setting again, quite likely due to improper re-basing. Restore the readonly= parameter to SCSI disks. For IDE disks this is supposed to be rejected; add an assert. And there is a bare ad-hoc disk drive string in libxl__build_device_model_args_new, which we also update. This is XSA-266. Reported-by: Andrew Reimers <andrew.reimers@xxxxxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> master commit: dd64d3c41a2d15139c3a35d22d4cb6b78f4c5c59 master date: 2018-06-28 09:05:06 +0200 commit 500d567b08ef890dddafdfaf0ac47ee63a48a0dd Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx> Date: Thu Jun 28 11:22:55 2018 +0200 libxl: qemu_disk_scsi_drive_string: Break out common parts of disk config The generated configurations are identical apart from, in some cases, reordering of the id=%s element. So, overall, no functional change. This is part of XSA-266. Reported-by: Andrew Reimers <andrew.reimers@xxxxxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> master commit: 724e5aa31b58d1e430ad36b484cf0ec021497399 master date: 2018-06-28 09:04:55 +0200 commit 5fd28d27d3f7840e4c6724e67936fed57a638155 Author: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Date: Thu Jun 28 11:22:30 2018 +0200 x86: Refine checks in #DB handler for faulting conditions One of the fix for XSA-260 (c/s 75d6828bc2 "x86/traps: Fix handling of #DB exceptions in hypervisor context") added some safety checks to help avoid livelocks of #DB faults. While a General Detect #DB exception does have fault semantics, hardware clears %dr7.gd on entry to the handler, meaning that it is actually safe to return to. Furthermore, %dr6.gd is guest controlled and sticky (never cleared by hardware). A malicious PV guest can therefore trigger the fatal_trap() and crash Xen. Instruction breakpoints are more tricky. The breakpoint match bits in %dr6 are not sticky, but the Intel manual warns that they may be set for non-enabled breakpoints, so add a breakpoint enabled check. Beyond that, because of the restriction on the linear addresses PV guests can set, and the fault (rather than trap) nature of instruction breakpoints (i.e. can't be deferred by a MovSS shadow), there should be no way to encounter an instruction breakpoint in Xen context. However, for extra robustness, deal with this situation by clearing the breakpoint configuration, rather than crashing. This is XSA-265 Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx> master commit: 17bf51297220dcd74da29de99320b6b1c72d1fa5 master date: 2018-06-28 09:04:20 +0200 commit d6154125d7a3d3d270d9888c0179ae6461b6bab0 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:21:57 2018 +0200 x86/mm: don't bypass preemption checks While unlikely, it is not impossible for a multi-vCPU guest to leverage bypasses of preemption checks to drive Xen into an unbounded loop. This is XSA-264. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: 17608703c65bf080b0a9f024f9b370872b9f2c05 master date: 2018-06-28 09:03:09 +0200 commit 9a7fa685f999c5166f3a4688e2596f3a9f36a9cf Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:20:24 2018 +0200 x86/EFI: further correct FPU state handling around runtime calls We must not leave a vCPU with CR0.TS clear when it is not in fully eager mode and has not touched non-lazy state. Instead of adding a 3rd invocation of stts() to vcpu_restore_fpu_eager(), consolidate all of them into a single one done at the end of the function. Rename the function at the same time to better reflect its purpose, as the patches touches all of its occurences anyway. The new function parameter is not really well named, but "need_stts_if_not_fully_eager" seemed excessive to me. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Reviewed-by: Paul Durrant <paul.durrant@xxxxxxxxxx> master commit: 23839a0fa0bbe78c174cd2bb49083e153f0f99df master date: 2018-06-26 15:23:08 +0200 commit b736afdea436f8028342f8305c037a0e89d23753 Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:19:43 2018 +0200 x86/EFI: fix FPU state handling around runtime calls There are two issues. First, the nonlazy xstates were never restored after returning from the runtime call. Secondly, with the fully_eager_fpu mitigation for XSA-267 / LazyFPU, the unilateral stts() is no longer correct, and hits an assertion later when a lazy state restore tries to occur for a fully eager vcpu. Fix both of these issues by calling vcpu_restore_fpu_eager(). As EFI runtime services can be used in the idle context, the idle assertion needs to move until after the fully_eager_fpu check. Introduce a "curr" local variable and replace other uses of "current" at the same time. Reported-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> Tested-by: Juergen Gross <jgross@xxxxxxxx> master commit: 437211cb696515ee5bd5dae0ab72866c9f382a33 master date: 2018-06-21 11:35:46 +0200 commit b9b9d9ed1d3205d0256eb8baab22a95e9b75313c Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:18:50 2018 +0200 x86: correct default_xen_spec_ctrl calculation Even with opt_msr_sc_{pv,hvm} both false we should set up the variable as usual, to ensure proper one-time setup during boot and CPU bringup. This then also brings the code in line with the comment immediately ahead of the printk() being modified saying "irrespective of guests". Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: d6239f64713df819278bf048446d3187c6ac4734 master date: 2018-05-29 12:38:52 +0200 commit 028656f0424fad1a9626ee05737d7bd2b271c2ce Author: Jan Beulich <jbeulich@xxxxxxxx> Date: Thu Jun 28 11:18:06 2018 +0200 libxc/x86/PV: don't hand through CPUID leaf 0x80000008 as is Just like for HVM the feature set should be used for EBX output, while EAX should be restricted to the low 16 bits and ECX/EDX should be zero. Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx> Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx> master commit: 849cc9ac56eff8a8d575ed9f484aad72f383862c master date: 2018-05-29 10:51:02 +0100 (qemu changes not included) _______________________________________________ osstest-output mailing list osstest-output@xxxxxxxxxxxxxxxxxxxx https://lists.xenproject.org/mailman/listinfo/osstest-output
|
 |
Lists.xenproject.org is hosted with RackSpace, monitoring our |