[win-pv-devel] [PATCH 1/2] Squash buffer overlow error messages in transmit

[Paul Durrant <paul.durrant@xxxxxxxxxx>]

Occasionally packets are too fragmented to fit into the maximum number of
requests allowed by the netif protocol. In this case the packet preparation
function will fail with STATUS_BUFFER_OVERFLOW and the alternative copy-
coalesce prepation function will be called. These error messages are
therefore un-interesting (since the number of packets directly granted vs.
those that were copied is available in the statistics dump initiated by the
debug VIRQ).
This patch squashes the error messages to avoid filling logs.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenvif/transmitter.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index 8125a5a..29d17fa 100644
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -787,7 +787,8 @@ __TransmitterRingGrantPayload(
 
 fail3:
 fail2:
-    Error("fail2\n");
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail2\n");
 
     if (Fragment != NULL) {
         ASSERT3P(Fragment->Context, ==, Packet);
@@ -800,7 +801,8 @@ fail2:
     }
 
 fail1:
-    Error("fail1 (%08x)\n", status);
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail1 (%08x)\n", status);
 
     ASSERT3P(Fragment, ==, NULL);
 
-- 
2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel