[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[win-pv-devel] [PATCH 1/2] Squash buffer overlow error messages in transmit

Occasionally packets are too fragmented to fit into the maximum number of
requests allowed by the netif protocol. In this case the packet preparation
function will fail with STATUS_BUFFER_OVERFLOW and the alternative copy-
coalesce prepation function will be called. These error messages are
therefore un-interesting (since the number of packets directly granted vs.
those that were copied is available in the statistics dump initiated by the
debug VIRQ).
This patch squashes the error messages to avoid filling logs.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
 src/xenvif/transmitter.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/xenvif/transmitter.c b/src/xenvif/transmitter.c
index 8125a5a..29d17fa 100644
--- a/src/xenvif/transmitter.c
+++ b/src/xenvif/transmitter.c
@@ -787,7 +787,8 @@ __TransmitterRingGrantPayload(
-    Error("fail2\n");
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail2\n");
     if (Fragment != NULL) {
         ASSERT3P(Fragment->Context, ==, Packet);
@@ -800,7 +801,8 @@ fail2:
-    Error("fail1 (%08x)\n", status);
+    if (status != STATUS_BUFFER_OVERFLOW)
+        Error("fail1 (%08x)\n", status);
     ASSERT3P(Fragment, ==, NULL);

win-pv-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.