[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [win-pv-devel] [PATCH] Fix memory leak in __LinkGetImageBase()



> -----Original Message-----
> From: win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:win-pv-devel-
> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Kostas Ladopoulos
> Sent: 22 January 2015 15:17
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Konstantinos Ladopoulos
> Subject: [win-pv-devel] [PATCH] Fix memory leak in __LinkGetImageBase()
> 
> The in-function allocated QueryInfo object was correctly freed for all error
> cases, but not the successful one.
> 
> Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@xxxxxxxxxx>

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

...and applied. Thanks!

  Paul

> ---
>  src/xenvif/link.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/xenvif/link.c b/src/xenvif/link.c
> index 269ce69..27a502b 100644
> --- a/src/xenvif/link.c
> +++ b/src/xenvif/link.c
> @@ -119,6 +119,8 @@ again:
>  found:
>      *ImageBase = QueryInfo[Index].BasicInfo.ImageBase;
> 
> +    __LinkFree(QueryInfo);
> +
>      Trace("<====\n");
> 
>      return STATUS_SUCCESS;
> --
> 1.9.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.