[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[win-pv-devel] [PATCH] Fix memory leak



Verifier discovered a memory leak on shutdown of XENVIF. This is because
the per-ring path used for talking to multi-queue aware backends is not
freed in the case where there is only one queue. This patch simply removes
that check as it is incorrect.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenvif/frontend.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/xenvif/frontend.c b/src/xenvif/frontend.c
index 12b6287..7e9989a 100644
--- a/src/xenvif/frontend.c
+++ b/src/xenvif/frontend.c
@@ -238,7 +238,7 @@ FrontendFormatPath(
     NTSTATUS                status;
 
     Length = (ULONG)(strlen(__FrontendGetPath(Frontend)) +
-                     strlen("/queue-00") +
+                     strlen("/queue-XX") +
                      1) * sizeof (CHAR);
 
     Path = __FrontendAllocate(Length);
@@ -268,8 +268,7 @@ FrontendFreePath(
     IN  PCHAR               Path
     )
 {
-    if (__FrontendGetQueueCount(Frontend) == 1)
-        return;
+    UNREFERENCED_PARAMETER(Frontend);
 
     __FrontendFree(Path);
 }
-- 
2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.