Re: [win-pv-devel] [PATCH] Windows Server 2008 compatibility fix

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:win-pv-devel-
> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Fabio Fantoni
> Sent: 30 March 2015 15:21
> To: Paul Durrant; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Paul Durrant
> Subject: Re: [win-pv-devel] [PATCH] Windows Server 2008 compatibility fix
> 
> Il 30/03/2015 14:51, Paul Durrant ha scritto:
> > Use of the CONNECT_FULLY_SPECIFIED_GROUP flag to
> IoConnectInterruptEx() is
> > not supported prior to Windows 7, so when Group == 0 (which will always
> be
> > true for any OS prior to Windows 7) just use CONNECT_FULLY_SPECIFIED
> > in which case it is documented that Windows will assume Group == 0.
> 
> Thanks, I want test it with the official build (I saw git push one hour
> ago or more) but downloading it seems don't updated (files changes on 24
> march).
> The automatic build system do a new build after git push or similar and
> now have a problem or is different case?
> 

It's still building! The build VM does a full SDV build. It's being going for 1 
hr 27 mins so far. Should hopefully be done in about another 30 mins or so. SDV 
is sloooooow :-/

  Paul

> Thanks for any reply and sorry if I bother you.
> 
> >
> > Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
> > ---
> >   src/xenbus/fdo.c | 5 ++++-
> >   1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/src/xenbus/fdo.c b/src/xenbus/fdo.c
> > index 8d8b125..3c3e9a0 100644
> > --- a/src/xenbus/fdo.c
> > +++ b/src/xenbus/fdo.c
> > @@ -1857,7 +1857,6 @@ FdoConnectInterrupt(
> >           (*Interrupt)->Line = Raw->u.Interrupt.Vector;
> >
> >       RtlZeroMemory(&Connect, sizeof
> (IO_CONNECT_INTERRUPT_PARAMETERS));
> > -    Connect.Version = CONNECT_FULLY_SPECIFIED_GROUP;
> >       Connect.FullySpecified.PhysicalDeviceObject =
> __FdoGetPhysicalDeviceObject(Fdo);
> >       Connect.FullySpecified.ShareVector = (BOOLEAN)(Translated-
> >ShareDisposition == CmResourceShareShared);
> >       Connect.FullySpecified.InterruptMode = (*Interrupt)->InterruptMode;
> > @@ -1879,6 +1878,10 @@ FdoConnectInterrupt(
> >           Connect.FullySpecified.ProcessorEnableMask = Translated-
> >u.Interrupt.Affinity;
> >       }
> >
> > +    Connect.Version = (Connect.FullySpecified.Group != 0) ?
> > +                      CONNECT_FULLY_SPECIFIED_GROUP :
> > +                      CONNECT_FULLY_SPECIFIED;
> > +
> >       status = IoConnectInterruptEx(&Connect);
> >       if (!NT_SUCCESS(status))
> >           goto fail2;
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel