Re: [win-pv-devel] [PATCH 01/03] Fix ASSERT in BlockRingDestroy

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:win-pv-devel-
> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Paul Durrant
> Sent: 05 June 2015 14:26
> To: Fabio Fantoni; Owen Smith; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Subject: Re: [win-pv-devel] [PATCH 01/03] Fix ASSERT in BlockRingDestroy
> 
> > -----Original Message-----
> > From: Fabio Fantoni [mailto:fabio.fantoni@xxxxxxx]
> > Sent: 05 June 2015 14:08
> > To: Paul Durrant; Owen Smith; win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> > Subject: Re: [win-pv-devel] [PATCH 01/03] Fix ASSERT in BlockRingDestroy
> >
> > Il 05/06/2015 13:51, Paul Durrant ha scritto:
> > >> -----Original Message-----
> > >> From: Fabio Fantoni [mailto:fabio.fantoni@xxxxxxx]
> > >> Sent: 05 June 2015 12:16
> > >> To: Owen Smith; win-pv-devel@xxxxxxxxxxxxxxxxxxxx; Paul Durrant
> > >> Subject: Re: [win-pv-devel] [PATCH 01/03] Fix ASSERT in
> BlockRingDestroy
> > >>
> > >> Il 20/05/2015 10:58, Owen Smith ha scritto:
> > >>> Also fixes a typo in blockring (Recieved -> Received)
> > >>>
> > >>> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> > >> Hi, I saw that this patch and others of the serie are still not applied
> > >> in git repository after some weeks, why?
> > >>
> > > Owen told me (offline) that he is planning to post a v2, so I'm waiting 
> > > for
> > that.
> > >
> > >    Paul
> >
> > Thanks for reply.
> > I saw also a strange thing, I downloaded updated winpv build today, I
> > saw xenvif last files change at 21 april but in git there is another
> > (latest) commit (fix) at 8 may.
> >
> 
> The public build VM appears to be offline. I will investigate.
> 

The build VM had crashed. It's now back up and XENVIF is building.

  Paul

> Thanks,
> 
>   Paul
> 
> > >
> > >> Thanks for any reply and sorry for my bad english.
> > >>
> > >>> ---
> > >>>    src/xenvbd/blockring.c | 10 ++++++----
> > >>>    1 files changed, 6 insertions(+), 4 deletions(-)
> > >>>
> > >>> diff --git a/src/xenvbd/blockring.c b/src/xenvbd/blockring.c
> > >>> index 35ffb3b..b6b6539 100644
> > >>> --- a/src/xenvbd/blockring.c
> > >>> +++ b/src/xenvbd/blockring.c
> > >>> @@ -58,7 +58,7 @@ struct _XENVBD_BLOCKRING {
> > >>>        PVOID                           Grants[XENVBD_MAX_RING_PAGES];
> > >>>        ULONG                           Outstanding;
> > >>>        ULONG                           Submitted;
> > >>> -    ULONG                           Recieved;
> > >>> +    ULONG                           Received;
> > >>>    };
> > >>>
> > >>>    #define MAX_NAME_LEN                64
> > >>> @@ -267,6 +267,8 @@ BlockRingDestroy(
> > >>>        BlockRing->Frontend = NULL;
> > >>>        BlockRing->DeviceId = 0;
> > >>>        BlockRing->Order = 0;
> > >>> +    BlockRing->Submitted = 0;
> > >>> +    BlockRing->Received = 0;
> > >>>        RtlZeroMemory(&BlockRing->Lock, sizeof(KSPIN_LOCK));
> > >>>
> > >>>        ASSERT(IsZeroMemory(BlockRing, sizeof(XENVBD_BLOCKRING)));
> > >>> @@ -465,7 +467,7 @@ BlockRingDebugCallback(
> > >>>                     "BLOCKRING: Requests  : %d / %d / %d\n",
> > >>>                     BlockRing->Outstanding,
> > >>>                     BlockRing->Submitted,
> > >>> -                 BlockRing->Recieved);
> > >>> +                 BlockRing->Received);
> > >>>
> > >>>        XENBUS_DEBUG(Printf, Debug,
> > >>>                     "BLOCKRING: SharedRing : 0x%p\n",
> > >>> @@ -497,7 +499,7 @@ BlockRingDebugCallback(
> > >>>                         GranterReference(Granter, 
> > >>> BlockRing->Grants[Index]));
> > >>>        }
> > >>>
> > >>> -    BlockRing->Submitted = BlockRing->Recieved = 0;
> > >>> +    BlockRing->Submitted = BlockRing->Received = 0;
> > >>>    }
> > >>>
> > >>>    VOID
> > >>> @@ -537,7 +539,7 @@ BlockRingPoll(
> > >>>                ++rsp_cons;
> > >>>
> > >>>                if (__BlockRingPutTag(BlockRing, Response->id, &Tag)) {
> > >>> -                ++BlockRing->Recieved;
> > >>> +                ++BlockRing->Received;
> > >>>                    --BlockRing->Outstanding;
> > >>>                    PdoCompleteResponse(Pdo, Tag, Response->status);
> > >>>                }
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel