[win-pv-devel] [PATCH] Avoid PDO namespace conflicts...

[Paul Durrant <pdurrant@xxxxxxxxx>]

...by encoding the driver major version in the upper byte of the
revision.

This clearly implies that any future change in the driver major version
will start a new PDO namespace, but that it almost certainly the correct
thing to do in that case.

Signed-off-by: Paul Durrant <paul.durrant@xxxxxxxxxx>
---
 src/xenbus/pdo.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/xenbus/pdo.c b/src/xenbus/pdo.c
index 8b86f3b..58150d0 100644
--- a/src/xenbus/pdo.c
+++ b/src/xenbus/pdo.c
@@ -48,6 +48,7 @@
 #include "dbg_print.h"
 #include "assert.h"
 #include "util.h"
+#include "version.h"
 
 #define PDO_TAG 'ODP'
 
@@ -402,7 +403,7 @@ PdoSetRevisions(
     ULONG           Revision;
     NTSTATUS        status;
 
-    Revision = 0;
+    Revision = MAJOR_VERSION << 24;
 
     // Enumerate all possible combinations of exported interface versions 
since v1
     // and add a PDO revsion for each combination that's currently supported. 
Note that
@@ -460,7 +461,7 @@ PdoSetRevisions(
                                                      "RANGE_SET v%u "
                                                      "CACHE v%u "
                                                      "GNTTAB v%u "
-                                                     "EMULATED v%u\n",
+                                                     "EMULATED v%u "
                                                      "UNPLUG v%u\n",
                                                      Revision,
                                                      Suspend,
-- 
2.1.1


_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel