Re: [win-pv-devel] [PATCH 4/8] Remove PdoPnpSrb, since StorPort doesn't call for targets

[Paul Durrant <Paul.Durrant@xxxxxxxxxx>]

> -----Original Message-----
> From: win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:win-pv-devel-
> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Owen Smith
> Sent: 27 October 2015 11:16
> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> Cc: Owen Smith
> Subject: [win-pv-devel] [PATCH 4/8] Remove PdoPnpSrb, since StorPort
> doesn't call for targets
> 
> Signed-off-by: Owen Smith <owen.smith@xxxxxxxxxx>
> ---
>  src/xenvbd/fdo.c | 18 ------------------
>  src/xenvbd/pdo.c | 27 ---------------------------
>  src/xenvbd/pdo.h |  6 ------
>  3 files changed, 51 deletions(-)
> 
> diff --git a/src/xenvbd/fdo.c b/src/xenvbd/fdo.c
> index 724d8ea..593875e 100644
> --- a/src/xenvbd/fdo.c
> +++ b/src/xenvbd/fdo.c
> @@ -1565,23 +1565,6 @@ FdoFindAdapter(
>      return SP_RETURN_FOUND;
>  }
> 
> -static FORCEINLINE VOID
> -__FdoSrbPnp(
> -    __in PXENVBD_FDO                 Fdo,
> -    __in PSCSI_PNP_REQUEST_BLOCK     Srb
> -    )
> -{
> -    if (!(Srb->SrbPnPFlags & SRB_PNP_FLAGS_ADAPTER_REQUEST)) {
> -        PXENVBD_PDO     Pdo;
> -
> -        Pdo = __FdoGetPdo(Fdo, Srb->TargetId);
> -        if (Pdo) {
> -            PdoSrbPnp(Pdo, Srb);
> -            PdoDereference(Pdo);
> -        }
> -    }
> -}
> -
>  BOOLEAN
>  FdoBuildIo(
>      __in PXENVBD_FDO                 Fdo,
> @@ -1600,7 +1583,6 @@ FdoBuildIo(
> 
>          // dont pass to StartIo
>      case SRB_FUNCTION_PNP:
> -        __FdoSrbPnp(Fdo, (PSCSI_PNP_REQUEST_BLOCK)Srb);
>          Srb->SrbStatus = SRB_STATUS_SUCCESS;
>          break;

I think this whole case should go then. I'll make that change, so...

Acked-by: Paul Durrant <paul.durrant@xxxxxxxxxx>

>      case SRB_FUNCTION_ABORT_COMMAND:
> diff --git a/src/xenvbd/pdo.c b/src/xenvbd/pdo.c
> index c0447db..172fa67 100644
> --- a/src/xenvbd/pdo.c
> +++ b/src/xenvbd/pdo.c
> @@ -2210,33 +2210,6 @@ PdoStartIo(
>      }
>  }
> 
> -VOID
> -PdoSrbPnp(
> -    __in PXENVBD_PDO             Pdo,
> -    __in PSCSI_PNP_REQUEST_BLOCK Srb
> -    )
> -{
> -    switch (Srb->PnPAction) {
> -    case StorQueryCapabilities: {
> -        PSTOR_DEVICE_CAPABILITIES DeviceCaps = Srb->DataBuffer;
> -        PXENVBD_CAPS    Caps = FrontendGetCaps(Pdo->Frontend);
> -
> -        if (Caps->Removable)
> -            DeviceCaps->Removable = 1;
> -        if (Caps->Removable)
> -            DeviceCaps->EjectSupported = 1;
> -        if (Caps->SurpriseRemovable)
> -            DeviceCaps->SurpriseRemovalOK = 1;
> -
> -        DeviceCaps->UniqueID = 1;
> -
> -        } break;
> -
> -    default:
> -        break;
> -    }
> -}
> -
> 
> //=========================================================
> ====================
>  // PnP Handler
>  static FORCEINLINE VOID
> diff --git a/src/xenvbd/pdo.h b/src/xenvbd/pdo.h
> index fbd6681..1211174 100644
> --- a/src/xenvbd/pdo.h
> +++ b/src/xenvbd/pdo.h
> @@ -212,12 +212,6 @@ PdoStartIo(
>      __in PSCSI_REQUEST_BLOCK     Srb
>      );
> 
> -extern VOID
> -PdoSrbPnp(
> -    __in PXENVBD_PDO             Pdo,
> -    __in PSCSI_PNP_REQUEST_BLOCK Srb
> -    );
> -
>  // PnP Handler
>  __checkReturn
>  extern NTSTATUS
> --
> 1.9.4.msysgit.1
> 
> 
> _______________________________________________
> win-pv-devel mailing list
> win-pv-devel@xxxxxxxxxxxxxxxxxxxx
> http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel