Re: [win-pv-devel] [PATCH] Add a user mode library wrapper for XENIFACE IOCTLs

[RafaÅ WojdyÅa <omeg@xxxxxxxxxxxxxxxxxxxxxx>]

On 2015-11-05 17:49, Paul Durrant wrote:
>> -----Original Message-----
>> From: win-pv-devel-bounces@xxxxxxxxxxxxxxxxxxxx [mailto:win-pv-devel-
>> bounces@xxxxxxxxxxxxxxxxxxxx] On Behalf Of Rafal Wojdyla
>> Sent: 05 November 2015 14:22
>> To: win-pv-devel@xxxxxxxxxxxxxxxxxxxx
>> Subject: [win-pv-devel] [PATCH] Add a user mode library wrapper for
>> XENIFACE IOCTLs
>>
>> Signed-off-by: Rafal Wojdyla <omeg@xxxxxxxxxxxxxxxxxxxxxx>
>> ---
[...snip...]

>> +/*! \brief Open an unbound event channel
>> +    \param Xc Xencontrol handle returned by XcOpen()
>> +    \param RemoteDomain ID of a remote domain that will bind the channel
>> +    \param Event Handle to an event object that will receive event channel
>> notifications
>> +    \param Mask Set to TRUE if the event channel should be initially masked
>> +    \param LocalPort Port number that is assigned to the event channel
>> +    \return Error code
>> +*/
>> +XENCONTROL_API
>> +DWORD
>> +XcEvtchnBindUnbound(
> 
> Shouldn't this be XcEvtchnOpenUnbound()? The name seems a little odd.
> 
>   Paul

You're right, at the beginning I used names similar to what libxc has.
Open makes more sense here.


-- 
Rafał Wojdyła
Qubes Tools for Windows developer
https://www.qubes-os.org/

_______________________________________________
win-pv-devel mailing list
win-pv-devel@xxxxxxxxxxxxxxxxxxxx
http://lists.xenproject.org/cgi-bin/mailman/listinfo/win-pv-devel